From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517180412-2-12451061394539094093 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES enro, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517180411; b=d/sRyErz4LmPwDYKAZcrGNs6lZx8fmhV4azg9sf9Ays1tFt gxVpO6e8z8E6W728bVzxrnQXcvE1bnGuqOwYFP7QZUm2YpRADMHeWhXgyJmw+KFP 8yqiUMnX9QQGZaKXc9MNzkFj/Lfs98JLRqE+f7yjJfjz4atLu/xz9XfMGfFKPQ/x XyzG0YSLPE5vYgWcegzwtTVlCIBaCio/0cuiI5z8eMVH6855JZ8U9y2R9qqFo6Vo O1X3znLSCigI7Y+qWAUOsDkZxakuDK/mqXUY6y9dx7kkANiZ9wJe2KgMDkzHqKwW VNEpXHd92EzsDY6/Mrjwcqc/beYYYpwRGq8ckgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517180411; bh=7xHUBj nBuWJd+b7o4tT+QOehOYaTW1UmUpGEVIXkZXc=; b=amrc8gonl/NiTTe/Ef8NKr JLI8etsWgKj+9jeZ4aESj78E0Sdk5bWdObRtfeCQ/VIi8azOpQurZxwHtfBU2Eqi zkatMF32YVD95r7C1HcfHTJ2VqivXwnkhLJG+b7G8gHfWm/uWrJGYJ3ockk/Y6b8 n0ruhP4VynWUL3Pn75Sh5hm/5qD7sBKVAybHjj8cfUiBSvWhFjv8VTxSKLplh36z iso7LOcc9IyMH/d/JMyLpJpafH9Jp2WwiU11CAPq+HjegdL6j4O4IuFXcP9mvxow 7xXzMW+Oc+tCYCQUvBK+x7rPXgfdueQunwD+kc2FDvwYGBNwHB3VjEHb3E2esGvg == ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=E6d+BIrS x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=E6d+BIrS x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbeA1W74 (ORCPT ); Sun, 28 Jan 2018 17:59:56 -0500 Received: from mail-bn3nam01on0113.outbound.protection.outlook.com ([104.47.33.113]:60480 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753552AbeA1W1w (ORCPT ); Sun, 28 Jan 2018 17:27:52 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Takuo Koguchi , Takuo Koguchi , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 084/100] spi: sun4i: disable clocks in the remove function Thread-Topic: [PATCH AUTOSEL for 4.14 084/100] spi: sun4i: disable clocks in the remove function Thread-Index: AQHTmIcZ4UIr8+DgF0yUgwu2kG8Qew== Date: Sun, 28 Jan 2018 22:26:53 +0000 Message-ID: <20180128222547.7398-84-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1018;7:FHppqCFh41MnIDSPkqDWq2DxfMCf30sWsToJVsBmFQ/5Z6ylRlzB9zxvRR7Gac0snobRe2tJ5/5hzAwOXheQwA1mRTtNmg0nex6vdbTCzHfEjNC2BWj5zKgwCLv6GrlejVrTN4VaQSvnNyuK3Gkxs6A4a6pJoEvrb3eW6C1d07IJnnDlCCqQtKXtrlICIeSGOBfiPxMIyZMuMpai72KGdjdDAi0j06sX6jUgKxlQivwlULQXzBij1ox1+OWVNIpd x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dff3abce-d05a-4ecb-03d6-08d5669e5960 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1018; x-ms-traffictypediagnostic: MW2PR2101MB1018: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(58145275503218); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1018;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1018; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39380400002)(39860400002)(366004)(346002)(376002)(199004)(189003)(53936002)(2501003)(6436002)(575784001)(86362001)(6486002)(5250100002)(26005)(102836004)(6512007)(59450400001)(76176011)(6116002)(2900100001)(3846002)(36756003)(305945005)(7736002)(316002)(3660700001)(22452003)(3280700002)(54906003)(110136005)(99286004)(186003)(97736004)(1076002)(86612001)(81166006)(6666003)(2906002)(106356001)(14454004)(66066001)(4326008)(68736007)(5660300001)(25786009)(8936002)(10290500003)(81156014)(72206003)(107886003)(10090500001)(478600001)(2950100002)(39060400002)(105586002)(8676002)(6506007)(22906009)(32563001)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1018;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: YQSJL28gPQo2YpebnxevMLC1hYG5oWBevtIvOMEsu/rL+jHdC2z8WXCCVmR1x70hL8+tRuCKWspXdXxcd7uCFA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: dff3abce-d05a-4ecb-03d6-08d5669e5960 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:53.8971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1018 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Takuo Koguchi [ Upstream commit c810daba0ab5226084a56893a789af427a801146 ] mclk and hclk need to be disabled. Since pm_runtime_disable does not disable the clocks, use pm_runtime_force_suspend instead. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635c28f3..41410031f8e9 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,7 +525,7 @@ static int sun4i_spi_probe(struct platform_device *pdev= ) =20 static int sun4i_spi_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); + pm_runtime_force_suspend(&pdev->dev); =20 return 0; } --=20 2.11.0