From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1369136-1517180320-2-7040723042268873364 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517180319; b=R5LGQXLeIaZueHOaPcQpejU6su0lk6aD3l0kZFQscG9ZhLY SEQSxSfaZLwotDsT8sUV4U+K1kM6fTTo8CUVdu2FBGLcLt/EUMz9/QxQqpxeIoJ1 Ca0OqqiNu0N8B/HPKB3AzS/M6AS1ZwV9kMBQJNe4ipL35L8GdTOqHW2MmZWL7wEY ov77p7/L4NoTZUvFMQfsEGWmM2bnvTX+qhVd8OsAJKfNQttAtKQVBpY1tCQ1TVU/ EZMR3mfBKlvYafrhowXSYPVcuy5Kn+JPzAIR9eWpHX7yq0GJsLgxPIKzpZgAx94j Vp+CAU8pVJFgDFp8CMjPx4Ct7zcSsLQO+GHuVZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517180319; bh=kyjpBO nfso4dXTQhtJLPYAoFlqR6AaRRkTBSIBeUl4k=; b=ar5h3VZKDZ+pHnOxoqjb7D SZsFaVRcWA5m+F8qswDxEajqEy+eY7SrzeQfWUuVJuWwmVhl5l2ydjGL8I+PX1+Z iculC1BBMPWxUlZi8UGlGuYv/m5n/jrv004mhOp6g34BJoibwNYke1oIdfJyHmjz K+VtAQnNesOo97OvUW3YT4L1dkPDtLlUx0SnUAbmH280f48NYUceGk+F1Td+an1H 24lgaz58P9/qvFxnn+aiFF9rQc8WtemLTQ31BWOOYcgEQZhqxzhcVht7vG/aJ4Pw CntLDKp/xsImA5XAtmK81T2ENXalB4PTvlB9YI/GCz6aeOhHay8zIfgsdl/PEnfQ == ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=J0LZc/Rw x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=J0LZc/Rw x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753643AbeA1W2U (ORCPT ); Sun, 28 Jan 2018 17:28:20 -0500 Received: from mail-dm3nam03on0125.outbound.protection.outlook.com ([104.47.41.125]:54546 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753636AbeA1W2S (ORCPT ); Sun, 28 Jan 2018 17:28:18 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Tobias Jordan , Vinod Koul , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 091/100] dmaengine: jz4740: disable/unprepare clk if probe fails Thread-Topic: [PATCH AUTOSEL for 4.14 091/100] dmaengine: jz4740: disable/unprepare clk if probe fails Thread-Index: AQHTmIccfFLZkYwzSEOJAutUEimi6g== Date: Sun, 28 Jan 2018 22:26:59 +0000 Message-ID: <20180128222547.7398-91-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1097;7:Cj4jUeVOPcrZZQrJvYklZKHAZcttsSpiVczROsmfY+RLjMgL+YLBtDkQgjxj98oHN5vTq6tNpgFsl/g5CWeCQyaeVi3vDudbM7Npf3Ci5vn7E4Iq1bg7J2ARpBhEzSStrgEXQbBdbFMqZkb0vciu6fgOS8HKWAdrtDbsz/1T8qrhiynQdsjCI+LUD+0eHs69B5TBr501xREHjUbNB8BtpvpEV5BwM9nZljwXX0kuyS9ehgv1Zphny/rgAOk67JpK x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0f88b3dc-e249-4123-187b-08d5669e6d34 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1097; x-ms-traffictypediagnostic: MW2PR2101MB1097: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1097;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1097; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(366004)(39380400002)(39860400002)(396003)(376002)(199004)(189003)(72206003)(14454004)(3280700002)(106356001)(4326008)(478600001)(10290500003)(76176011)(102836004)(3660700001)(59450400001)(25786009)(6506007)(105586002)(316002)(6486002)(97736004)(22452003)(186003)(99286004)(110136005)(54906003)(107886003)(26005)(86362001)(8676002)(81156014)(2906002)(1076002)(81166006)(68736007)(3846002)(6116002)(305945005)(7736002)(36756003)(86612001)(10090500001)(6512007)(2950100002)(66066001)(5660300001)(53936002)(6666003)(8936002)(6436002)(2501003)(2900100001)(5250100002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1097;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: TU4xZ3Oi/VillMdFHsAZa56Bh02UCIvKhzd4tIiMhb/NF3TT1Q/A07YCDdB2pC8ZIYELQYlt+taOOEpE4xBX9w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f88b3dc-e249-4123-187b-08d5669e6d34 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:59.2480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1097 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Tobias Jordan [ Upstream commit eb9436966fdc84cebdf222952a99898ab46d9bb0 ] in error path of jz4740_dma_probe(), call clk_disable_unprepare() to clean up. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 25ce6c35fea0 MIPS: jz4740: Remove custom DMA API Signed-off-by: Tobias Jordan Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/dma-jz4740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c index d50273fed715..afd5e10f8927 100644 --- a/drivers/dma/dma-jz4740.c +++ b/drivers/dma/dma-jz4740.c @@ -555,7 +555,7 @@ static int jz4740_dma_probe(struct platform_device *pde= v) =20 ret =3D dma_async_device_register(dd); if (ret) - return ret; + goto err_clk; =20 irq =3D platform_get_irq(pdev, 0); ret =3D request_irq(irq, jz4740_dma_irq, 0, dev_name(&pdev->dev), dmadev)= ; @@ -568,6 +568,8 @@ static int jz4740_dma_probe(struct platform_device *pde= v) =20 err_unregister: dma_async_device_unregister(dd); +err_clk: + clk_disable_unprepare(dmadev->clk); return ret; } =20 --=20 2.11.0