From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517179145-2-9214781409361130645 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179145; b=Ninda47jOBf1XAuSZl3MofezTpIfRxMufbod9mVKqWVA0C5 14wLlBwoc9xASUntZyaqhv9aQ4b7mQsgjNJ3XyTRyXXf6rufG6zwQnodi/tDt8pO uv4wTI4mNYOUTysEoxTMA8gcJ5cs2CTNW4Uh1kzzMCt7mu2psKRmW9DlS8vwx6SS upu2GA7Jv8KjLcvV62aLvKWcx2P3nKx0qEcuNc0WWh3iJsSaxX0Nxfx0qX3jgsOe 9lYhNLBRljcp2AXX1KSF+Ud+soJV3c3MygJnMQ1xEVvsY9EbQzsb/mUIwtdy91Ki R113UZTltAxk9hyQy07Jn8/LHUpHZITtr69xXlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179145; bh=GQTdhK znRDAPsc7UTFrYh5wO8YeDbcQ39kX0w9hPEZQ=; b=YaVX+AYoVihGgvGm19aqaU n0seTtXcrEm0ZjSXpbzAUweHz42W8ik1eq3xrl2nLxIWFCHHtqZoeEWCGHDB9yTq oZIsxJl8yyt7iwKNJ9Zxt8ls0JQiZuvilC8S1xLVthOaPLK1926EFF5+quEcyshF a1ky7lCVVE5DBHirLHe5KH25VzrfZ3vYTjcL5Mz22Yfct+imez/GFO88ZAIA6YmA ScD7lAx8pQ+XctPN57WKqBXRRIHV+dGKSLoSlDJYeREkWc7G0E8fagGj7wJ5DLTA 9qXrtV9SigBP2QwROSRkIQIJ6Xailw4eOuNyu/7cFHCt+mWMf+j4u12zGF1vcflA == ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=WtspOxS9 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=WtspOxS9 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbeA1WaD (ORCPT ); Sun, 28 Jan 2018 17:30:03 -0500 Received: from mail-bn3nam01on0127.outbound.protection.outlook.com ([104.47.33.127]:53399 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753789AbeA1W3x (ORCPT ); Sun, 28 Jan 2018 17:29:53 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Will Deacon , Matthew Wilcox , Jonathan Corbet , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 11/36] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Topic: [PATCH AUTOSEL for 4.4 11/36] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Index: AQHTmIdSkyTyYhKfikeTA41Tkm3baQ== Date: Sun, 28 Jan 2018 22:28:30 +0000 Message-ID: <20180128222815.29479-11-alexander.levin@microsoft.com> References: <20180128222815.29479-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222815.29479-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1115;7:8wjD3Y0u6TykIrhR5CS1LlUlgqxhi9eFjX4LP3pttqzGQ0Wlu+pjUasVQm613u1h/UtS44TIuZDUfDVrFDZLuX9XlcEGlMdFeDtlGRvCetBsrs7YN54HdOCck9KPhFn/YcwTzS+TgGpZEg5WZFSMcLV83BhqLGTtSGmbqNEPbnsYQQ2MT9vXix/aZbNyknpvlPfnKql3H6ftSK/A+IGWqnZHNkhuXA3XGUnfuelis1OA4qeyS1x/sBjh0wSsgz/7 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 614349ef-4746-4cdd-fb50-08d5669ea23f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1115; x-ms-traffictypediagnostic: MW2PR2101MB1115: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1115;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1115; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39860400002)(396003)(366004)(39380400002)(199004)(189003)(3280700002)(2906002)(4326008)(6486002)(6512007)(102836004)(53936002)(97736004)(1076002)(3660700001)(105586002)(3846002)(54906003)(110136005)(186003)(66066001)(25786009)(26005)(305945005)(6116002)(99286004)(107886003)(6436002)(81156014)(5250100002)(81166006)(8676002)(22452003)(86362001)(2950100002)(36756003)(316002)(478600001)(106356001)(8936002)(2501003)(5660300001)(7736002)(6666003)(72206003)(10090500001)(68736007)(10290500003)(86612001)(2900100001)(14454004)(76176011)(59450400001)(6506007)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1115;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: Qha8DE+YrytgD4wBmUkGUu+BGh9vVCoLKi8Ys7J05uKtGNHPeC7YZT3fB99CXc2UDzEQqB6+AZKbhwVEPK5Xyw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 614349ef-4746-4cdd-fb50-08d5669ea23f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:28:30.2376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1115 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot= parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=3D1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 638a38e1b419..bba8ad9c4f2c 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -2742,4 +2742,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } =20 -exit($errors); +exit($output_mode eq "none" ? 0 : $errors); --=20 2.11.0