From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517179356-2-4269626278230688351 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES enro, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179355; b=ZlbeUf0TSIDqpo5GPnT4gMmHZYMNxVdwyaHiLNkYzHv90ZP Z7GL67BRWltjyqZ8hw+hKPOOjsODYx40Z8/g34u7fa0j4ZYjIkS06kYtyAaN7zs9 2ioRAP50We3vJSQPyjeWlbFvzpzYS16MOGpaw9KnVmHfZQlm//bv2j0ASDjJZGi0 psw6eJjsIwLTspOjkesMCrzawpVgOFbndv7NA3CFjuca7WLz2/f/yErz24mrVGdX IIT3NRI/Wuenb7k+CNmdZCwIem5asFpXYq98V8LJMdfFo3tPxcLMdKSeOhyF3gQD u3cMcycIN/wXiAaEGpaFaYQyVnNfapPC/piyjXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179355; bh=8jORIa 7OVYWAqpIFx2jL6Fjk0IRcxd17p3Wo6y/lNWc=; b=wDzlHT2TZnLJjaRKjpoCU9 WV6R+oincllqvjkKJwCoBLyZs80tDsm87KMA8yqe2b5B2m0RcQopD7U42kGu+V6H HEnBrHO6CnL6b1+svdvkmBy+wS95B1fkqAO1ZKKSrNwYtI/s8BVWONI7Y60aO1/0 yuFRv8Bu0FuX0Iu0+alElxqb+3Idj/fh+OlVy/f4FxGvyoAjFYGSfK904enijxoD 0pJHDAgMzJtbNikxRygn+IR3NxMeQvGtqdbgcEBvSqzs19lQ1JQmWE6muRwo4MMB ueTQTZbJnBduDY28/067gtH6D3vD8idnWEMS7xvUQZMd9yzfARl7cmfFK6qA/EHg == ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=eHD9y1Pz x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=eHD9y1Pz x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbeA1WmE (ORCPT ); Sun, 28 Jan 2018 17:42:04 -0500 Received: from mail-bn3nam01on0104.outbound.protection.outlook.com ([104.47.33.104]:34771 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753801AbeA1W3z (ORCPT ); Sun, 28 Jan 2018 17:29:55 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Stefan Haberland , Martin Schwidefsky , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 15/36] s390/dasd: prevent prefix I/O error Thread-Topic: [PATCH AUTOSEL for 4.4 15/36] s390/dasd: prevent prefix I/O error Thread-Index: AQHTmIdUEcVVAnmtDEWXzu4SwKbQFQ== Date: Sun, 28 Jan 2018 22:28:33 +0000 Message-ID: <20180128222815.29479-15-alexander.levin@microsoft.com> References: <20180128222815.29479-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222815.29479-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1115;7:69r4vu9TQivPP+WgZQZNGw9lgcjvQe0ZKnpDxXUVvFVcanElrSbnH2S2oG29QFysdSY/+4bOtIxXExJKZUK+zAjq2897NBMWXu873r9orQUDyViHmW0l+guqVD2XMV9bXyfyfl998WozIceE0qMAv+lpt1yQYXj0G7H/UmeWRM+6xwvQOJBFN/27vUCPpI2ivM0+kchgeKFuUPgSucRIT1SX6bdXvXXhEOMrhrtWovADC+okIGjQst9TAbEYNuCY x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1192d924-c036-44da-acfe-08d5669ea32a x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1115; x-ms-traffictypediagnostic: MW2PR2101MB1115: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(190383065149520)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1115;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1115; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39860400002)(396003)(366004)(39380400002)(199004)(189003)(3280700002)(2906002)(4326008)(6486002)(6512007)(102836004)(53936002)(97736004)(1076002)(3660700001)(105586002)(3846002)(54906003)(110136005)(186003)(66066001)(25786009)(26005)(305945005)(6116002)(99286004)(107886003)(6436002)(81156014)(5250100002)(81166006)(8676002)(22452003)(86362001)(2950100002)(36756003)(316002)(478600001)(106356001)(8936002)(2501003)(5660300001)(7736002)(6666003)(72206003)(10090500001)(68736007)(10290500003)(86612001)(2900100001)(14454004)(76176011)(59450400001)(6506007)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1115;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: BJRM8pykoNYa6pwf2bWNnAH8bq7CL/GaB7NsLDwuLCc74OZRG4ZIFMieXkd+ldLNdw4CBcPed505aAj6LR17Lw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1192d924-c036-44da-acfe-08d5669ea32a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:28:33.3378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1115 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Stefan Haberland [ Upstream commit da340f921d3454f1521671c7a5a43ad3331fbe50 ] Prevent that a prefix flag is set based on invalid configuration data. The validity.verify_base flag should only be set for alias devices. Usually the unit address type is either one of base, PAV alias or HyperPAV alias. But in cases where the unit address type is not set or any other value the validity.verify_base flag might be set as well. This would lead to follow on errors. Explicitly check for alias devices and set the validity flag only for them. Signed-off-by: Stefan Haberland Reviewed-by: Jan Hoeppner Signed-off-by: Martin Schwidefsky Signed-off-by: Sasha Levin --- drivers/s390/block/dasd_eckd.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.= c index 9083247f55a8..21d174e9ebdb 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c @@ -518,10 +518,12 @@ static int prefix_LRE(struct ccw1 *ccw, struct PFX_ec= kd_data *pfxdata, pfxdata->validity.define_extent =3D 1; =20 /* private uid is kept up to date, conf_data may be outdated */ - if (startpriv->uid.type !=3D UA_BASE_DEVICE) { + if (startpriv->uid.type =3D=3D UA_BASE_PAV_ALIAS) pfxdata->validity.verify_base =3D 1; - if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) - pfxdata->validity.hyper_pav =3D 1; + + if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) { + pfxdata->validity.verify_base =3D 1; + pfxdata->validity.hyper_pav =3D 1; } =20 /* define extend data (mostly)*/ @@ -3002,10 +3004,12 @@ static int prepare_itcw(struct itcw *itcw, pfxdata.validity.define_extent =3D 1; =20 /* private uid is kept up to date, conf_data may be outdated */ - if (startpriv->uid.type !=3D UA_BASE_DEVICE) { + if (startpriv->uid.type =3D=3D UA_BASE_PAV_ALIAS) + pfxdata.validity.verify_base =3D 1; + + if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) { pfxdata.validity.verify_base =3D 1; - if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) - pfxdata.validity.hyper_pav =3D 1; + pfxdata.validity.hyper_pav =3D 1; } =20 switch (cmd) { --=20 2.11.0