From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517179328-2-8647478677338923176 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179327; b=SWRxyTVuCmit0S2jGnoNzlc9EHoiLapdaiNjTu/josK6Zt7 JTin9NXeggGDeoT1+uDY0TXn8Tkjc7e17oS4YYE1T3gC47hyUmeGw4CtQma/hPrz HKGqzItaD+eQ44xlyWYizt3DpQ5/UAZJ4P/AW+qNxMIhgigvHN8X2wGxTgpLHomt KN/VGwMtrPuvMGOyvLumrnviVEuQC3yl7mWoAQu/3xJNbIs1OfYz6zxHOVZyHI+C XNoqtGLX9ADphHIWg5DBbhwTpMfvXGVewAwxfu1ohJr/hLghHpA8APdMr8HR3LTp OHBEMX3CY2L5GEB42uQjfpOpTCqoDpbxMqEIEHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179327; bh=i0CYfe a6oYk4mcbzY9+zctfllGrHmwGLIVJsJHxZgjo=; b=gUq49L7mmYhksdnOEy9mVv CfjW/4ZPhCBt0s5zsnF+d7BLDNwFrcwin6FRgxW9FVbc7vKVW03wp3OgK0WvyIlw qotYqhjl4/+xASx6UmFaOIhOBTRi39rh0cGCjR/Biq6ii1vV3ZLBqd0jImpZuYT9 0BPMvz9wFtGWOASaitB0prONsH/0k6FkwO/WkC9LREVIc9jOdUws9oaItLkwVoX0 pMpPzi/JLm0Q1HFYcuX82os5UVHXsaJWiRj1enKLC5yOuRDhL5jeK43wBRRjKKYK Hi6hrRQS3RY+IrkqymARlcOLKbVo7+WLDpBbmpwkdcsGqPBt6j0zh1PXbBUBWKKw == ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=SI4w9MKC x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=SI4w9MKC x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801AbeA1WmG (ORCPT ); Sun, 28 Jan 2018 17:42:06 -0500 Received: from mail-cys01nam02on0124.outbound.protection.outlook.com ([104.47.37.124]:11968 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753804AbeA1W3z (ORCPT ); Sun, 28 Jan 2018 17:29:55 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: "Gustavo A. R. Silva" , Vinod Koul , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 23/36] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Thread-Topic: [PATCH AUTOSEL for 4.4 23/36] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Thread-Index: AQHTmIdYQ8C4CfoKIk6Nb6T+5/PhDw== Date: Sun, 28 Jan 2018 22:28:39 +0000 Message-ID: <20180128222815.29479-23-alexander.levin@microsoft.com> References: <20180128222815.29479-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222815.29479-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1114;6:cn9CDIVoPiwHK/oe6ooxhtP+jDiZ5Y0Wbq8KwXccf3Q60hQYfBhmw8CEwigrEVhQd695O6ceGnQzSL21BdqAu3X4RpxYcLCbch2dhopz5Stbzb6VfOPBOl7gV9BAfOeMpZ6D7cPmDiDfb/VCK/3AroNmTNzsbC9hBROhPq4QdL4YuesCmb3D9mWs9Ze6q9KCpGxmL8cmZaxo14FSum0M2cljboQf38e9i4GhosanwQwHi4kP12++9F3Fuv2kI9nJGbQFaFX/+tGHI6CpfK1BRNWKSTliNidMlUfVOmKA5ir0fQlx84IsL4ZgBuzKmmwK9Dej/GfPzRMOYfHdzjaesYd+5VZj2XijNc5olug81zm1z7hiG6U/KpZw6xo7fLqs;5:GrSyApPaDwuHzz6g1ufZRJmwK/79m4SurqFDdHGduJFJf9oJmrLwHqi5tiEx/jnEKZ+ro/DAmaFbAPm5pnlYnRcW10SJ5iADEPLHaAxUNSiY0eC0qLPMl+QGpCN50zX/r0s/vvs5oURoc7Cs9Q8f+aw1YKSRTTif40Knspnuw+o=;24:okGAt341FTHCUYvCi8bHqhtQbTxISx8DwkidZwlNhXayqRLIYA073pyz0rT8OcU1Q0qbNyJ3uFILh5xfh7+Ms/FDtMKBrPN7Fd3b7fxJlCg=;7:MnEDsWoE+0brV8jhAejNwvQNZBaUsNABkGYR0oYiUtimuLUSqFxsn2BX28Bou/I2w/TGPMeNYXMeHLI0nIOT6TUKCEExQCt/3EKmzIxhMMpam9ffKhPRvxUnZfxfeq3vKdCo5xJitnzRDXg450KkozIzxmFq1NwkI8ebTvRZEQe2jY6ye2yo7x8NKWYZgTjPnx1FyiI4PE6e4bBreTxpzyhfEivYu9oig/z/bCjEwasiiu/vn5MKzhqpeg9HO19A x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f1b03416-3f26-49e9-388f-08d5669ea57a x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1114; x-ms-traffictypediagnostic: MW2PR2101MB1114: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1114;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1114; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(39380400002)(39860400002)(346002)(366004)(189003)(199004)(305945005)(186003)(110136005)(26005)(81156014)(7736002)(8936002)(6506007)(102836004)(81166006)(6116002)(3846002)(316002)(1076002)(6486002)(6436002)(105586002)(22452003)(72206003)(3660700001)(2950100002)(14454004)(107886003)(6666003)(59450400001)(10290500003)(99286004)(68736007)(2906002)(97736004)(478600001)(3280700002)(76176011)(8676002)(54906003)(86612001)(10090500001)(36756003)(86362001)(2900100001)(5660300001)(25786009)(4326008)(5250100002)(6512007)(53936002)(106356001)(2501003)(66066001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1114;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: Fpr674bCfiv89ADnspS7qPMJJ/VbgPJaTc2m14JTHZuJaSWG0xQ45V9qJJxvA/9PXvoFWTOIx5W9Y8N7a6m8fQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1b03416-3f26-49e9-388f-08d5669ea57a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:28:39.4752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1114 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: "Gustavo A. R. Silva" [ Upstream commit 62a277d43d47e74972de44d33bd3763e31992414 ] _xt_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _xt_ has been null checked. This issue was detected with the help of Coccinelle. Fixes: 4483320e241c ("dmaengine: Use Pointer xt after NULL check.") Signed-off-by: Gustavo A. R. Silva Acked-by: Ludovic Desroches Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/at_hdmac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 53d22eb73b56..be26f625bb3e 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -716,7 +716,7 @@ atc_prep_dma_interleaved(struct dma_chan *chan, unsigned long flags) { struct at_dma_chan *atchan =3D to_at_dma_chan(chan); - struct data_chunk *first =3D xt->sgl; + struct data_chunk *first; struct at_desc *desc =3D NULL; size_t xfer_count; unsigned int dwidth; @@ -728,6 +728,8 @@ atc_prep_dma_interleaved(struct dma_chan *chan, if (unlikely(!xt || xt->numf !=3D 1 || !xt->frame_size)) return NULL; =20 + first =3D xt->sgl; + dev_info(chan2dev(chan), "%s: src=3D%pad, dest=3D%pad, numf=3D%d, frame_size=3D%d, flags=3D0x%lx= \n", __func__, &xt->src_start, &xt->dst_start, xt->numf, --=20 2.11.0