From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517179172-2-10356750806411070865 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179172; b=vuE1byJHS7mkCqoMPPzlE21ao+HV0GSYzpQjvz7nkxuyGp1 NEy/NgrV5J3YaNbJZcQ06tSWWiDur9VRb7t3PK//dDENtXwqt/eAyRqdEboXouAN 0J5r/BHCqzShLQ/Om3MDpTaMRvv14U5XeUH8F4W14WR6SGjCy9W+pJZctOn8dN6Y 7bsn/1kpUkzkiUvGf2vDJTHqEUldSa5OSv+xC5QrTqvuA4SlrlxnUPu8DkMlpFcE yw9qgx+p0CW6wAcwRVE1ix2jhJX+mPzqaHE/je1ZOjF7KMxafyVIOOsPAjKbcBn6 qhPN6opbuWDmczGA/UFhqSgxlZvy09lwZsnuJJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179172; bh=8rfEHS +FkkcAcCysEOLJX76ST1KA1nxrymKE3yi2rOg=; b=miUimrU4KPTuictKyK0qNH Ra4PyhWWKrDkrzv7zkkH3k1UbOsL9/g1HqHlQoOIq4eo50SsjsDqNpwAooEVjJmL 18f8id8499wEWr8kvz3YBCQ0v8+t7lDHIaeeOtnuq16RjyekXSnWPuwbBO8HHvzD tWk3odSTKMW4xNfyTB0bDC+VQdHNGfMI4KatkaPbboR6X0ZMZaTujBFqdskm26nm BtW5a4OmjLcYyaXxgn7aIrckXTvAFycHoGqzH2gZE4J8mULDryOfmp+FVK1V+euL 9Wc/knzeTqQK0f+EUZZeQ68/78m/3/fzmR0+0CHDh017EN3fCdjCHVGKI3Pg+ycg == ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=jjSM3A5I x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=jjSM3A5I x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932491AbeA1WjN (ORCPT ); Sun, 28 Jan 2018 17:39:13 -0500 Received: from mail-cys01nam02on0124.outbound.protection.outlook.com ([104.47.37.124]:11968 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932433AbeA1WaC (ORCPT ); Sun, 28 Jan 2018 17:30:02 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Takuo Koguchi , Takuo Koguchi , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 29/36] spi: sun4i: disable clocks in the remove function Thread-Topic: [PATCH AUTOSEL for 4.4 29/36] spi: sun4i: disable clocks in the remove function Thread-Index: AQHTmIdbfbq82L8RwUaJwuetGmmvuA== Date: Sun, 28 Jan 2018 22:28:44 +0000 Message-ID: <20180128222815.29479-29-alexander.levin@microsoft.com> References: <20180128222815.29479-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222815.29479-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1114;7:7RXnR9Xzuy8xyrTqXN6SKd+Ik1DIc9jioGvgqSWhYm8zGe8R6NtMpjxseVqy4eEuNgK1KH65mZUV0WapMY1QQxyBypxWwPVj3Y0wKUMpKvN1dRuUl2MskyxHqQ1orqDATnFm59HQ+7rsp5MJ9GPuj1SSaOqDE53CYq3KnzyM9bXprxxhgAtpZBZOp1pMWT0/MuJ+UhdKCAL/yWO1NOWw0akKdFDFHEf3WQ/veCFbUROgC+RRJPuQMO0U0JEtDa+A x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 67cf1f9f-894d-45e0-7e03-08d5669ea740 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1114; x-ms-traffictypediagnostic: MW2PR2101MB1114: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(58145275503218); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1114;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1114; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(39380400002)(39860400002)(346002)(366004)(189003)(199004)(305945005)(186003)(110136005)(26005)(81156014)(7736002)(8936002)(6506007)(102836004)(81166006)(6116002)(3846002)(316002)(1076002)(6486002)(6436002)(105586002)(22452003)(72206003)(3660700001)(2950100002)(14454004)(107886003)(6666003)(59450400001)(10290500003)(99286004)(68736007)(2906002)(97736004)(478600001)(3280700002)(76176011)(8676002)(54906003)(86612001)(10090500001)(36756003)(575784001)(86362001)(2900100001)(5660300001)(25786009)(4326008)(5250100002)(6512007)(53936002)(106356001)(2501003)(39060400002)(66066001)(22906009)(32563001)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1114;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: tTxmTiaknEqtJyN7BsOJXvUix1L25WoLwUH4q83EcefM57pVKXZHGYGmY1xy2nLLhG1oGzzWzboPHo/N9ZUKlw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67cf1f9f-894d-45e0-7e03-08d5669ea740 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:28:44.5278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1114 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Takuo Koguchi [ Upstream commit c810daba0ab5226084a56893a789af427a801146 ] mclk and hclk need to be disabled. Since pm_runtime_disable does not disable the clocks, use pm_runtime_force_suspend instead. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index 39d7c7c70112..2eea3de5a668 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -458,7 +458,7 @@ static int sun4i_spi_probe(struct platform_device *pdev= ) =20 static int sun4i_spi_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); + pm_runtime_force_suspend(&pdev->dev); =20 return 0; } --=20 2.11.0