From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517178879-2-817411689913691932 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES enroca, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517178879; b=EddYX9DQ+A3cfu6BjWpZprnfScP+y0kwcRjU7inlN3qzZlX HKEa52NOLQsUZ1FNdBJer5zLdKHwSHJqphG/Ep+m1nG8pKZKctMabenahdyXmIV4 NmjSXV96yXM5fCrYTYvoqzF3CYQ5NwhgSNcjEWE9yUa5UI8mVdHhATLoBjo4RGkW pw3/Y+J0QOZyyStz4bIbSaIrcGGTkITmI5RDqwRYveCtzJ3fyxvCiWR9yxqlhNK1 j4P94Hq+QbdqVTSfHZ92xWtW5LCzZV84x/rtxbpsKyidnFO38Un1/x3VIyttAjdw R1obUk3+x9lmFYb+ZxtJc8a0JlfSvPsNZg87Pjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517178879; bh=slvqpT iy0Ohrxl6KD/B+yKDMOj2hsS9NGMKV1x+PUhg=; b=Mc41E2IQ03caiNDNDvbzzm y6wnoyFsshsShUBYCxeW9Hfc422StbLG7QnDx9054Svoz8gJbTioIZaXMPo/Q02J 9JqUdZFcQh1FEWdB3V3vVaX+kIMw5y2aIiyG9aUd54xzSwIdtfYmKhaM2S0wBtCJ 8olR+enceBpYsocZA1EcEJHB2MGtKrGWpKjlh+enFbfRod34JN1ZoV5qlA/dca5Q 2ryw+fL1K0nTNeWO2Cdihz2D3jNlszD0AXaP4cWHTvxSQSikE07n6riCaiFkGqcF GMam9gvRrt/LQJra/uuZeQxJxvcxCu0PdTqm+yhmwnwLaeybaX//fzej452pSqRg == ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=NDqOWOyw x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=NDqOWOyw x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbeA1WeV (ORCPT ); Sun, 28 Jan 2018 17:34:21 -0500 Received: from mail-cys01nam02on0129.outbound.protection.outlook.com ([104.47.37.129]:29515 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932621AbeA1Wah (ORCPT ); Sun, 28 Jan 2018 17:30:37 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Stefan Haberland , Martin Schwidefsky , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 10/25] s390/dasd: prevent prefix I/O error Thread-Topic: [PATCH AUTOSEL for 3.18 10/25] s390/dasd: prevent prefix I/O error Thread-Index: AQHTmIeBod+CrhhlS0uqx0Z0tywXRw== Date: Sun, 28 Jan 2018 22:29:48 +0000 Message-ID: <20180128222931.7781-10-alexander.levin@microsoft.com> References: <20180128222931.7781-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222931.7781-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1098;7:8NBXcFucT6kuBeU7P2GWMpY7BlzEBAyOos4DZkaQdCLYE5cr+Wf8nXERWzHah3WCB9dSCGsOEHuTm5zFnuGU9tMqWwKmHgu/iZa0fKppCtZaQy+/V4j7tKvaODSFpQpQV0NTphVPYBlFrhn7faVGrOQYr5f1EOovZX3/v3Vpvcwn+SH5Td5S2yMwU4JHKZG/BCLRbQmkwCwnsT6LcQa+8OI5nXYikzKk56aCimqyPJ76VNC25yraZ1GwMgO3Fi22 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 825b17ff-0d35-41a0-d7ad-08d5669ebd5f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(190383065149520)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1098;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(6666003)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(59450400001)(25786009)(107886003)(5250100002)(8676002)(110136005)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(76176011)(6512007)(6486002)(186003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1098;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: zKcM+R64xpDtzKLQtIieDY8WBV2YuYHNs4uO2Bt6Mwgm1z69yHuFeZLKCxutKDgyA7fALM1EuD23dlvIv8HlCg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 825b17ff-0d35-41a0-d7ad-08d5669ebd5f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:29:48.5152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Stefan Haberland [ Upstream commit da340f921d3454f1521671c7a5a43ad3331fbe50 ] Prevent that a prefix flag is set based on invalid configuration data. The validity.verify_base flag should only be set for alias devices. Usually the unit address type is either one of base, PAV alias or HyperPAV alias. But in cases where the unit address type is not set or any other value the validity.verify_base flag might be set as well. This would lead to follow on errors. Explicitly check for alias devices and set the validity flag only for them. Signed-off-by: Stefan Haberland Reviewed-by: Jan Hoeppner Signed-off-by: Martin Schwidefsky Signed-off-by: Sasha Levin --- drivers/s390/block/dasd_eckd.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.= c index d47f5b99623a..3a3e1dfcb032 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c @@ -518,10 +518,12 @@ static int prefix_LRE(struct ccw1 *ccw, struct PFX_ec= kd_data *pfxdata, pfxdata->validity.define_extent =3D 1; =20 /* private uid is kept up to date, conf_data may be outdated */ - if (startpriv->uid.type !=3D UA_BASE_DEVICE) { + if (startpriv->uid.type =3D=3D UA_BASE_PAV_ALIAS) pfxdata->validity.verify_base =3D 1; - if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) - pfxdata->validity.hyper_pav =3D 1; + + if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) { + pfxdata->validity.verify_base =3D 1; + pfxdata->validity.hyper_pav =3D 1; } =20 /* define extend data (mostly)*/ @@ -2969,10 +2971,12 @@ static int prepare_itcw(struct itcw *itcw, pfxdata.validity.define_extent =3D 1; =20 /* private uid is kept up to date, conf_data may be outdated */ - if (startpriv->uid.type !=3D UA_BASE_DEVICE) { + if (startpriv->uid.type =3D=3D UA_BASE_PAV_ALIAS) + pfxdata.validity.verify_base =3D 1; + + if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) { pfxdata.validity.verify_base =3D 1; - if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) - pfxdata.validity.hyper_pav =3D 1; + pfxdata.validity.hyper_pav =3D 1; } =20 switch (cmd) { --=20 2.11.0