From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517178785-2-7144979525058686266 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517178784; b=Sj7Fey2ClcRSimVFinqAdZEQZZmTc2SupOY7BVlKpuVI1uR ECyXlVZzoP7XjRkR7h3DgRIMAtuNO9rQlGf+KwXhCCL3JMyILHvK8FnXSUrbunj6 O8R0bbbECrOXHdz8nrDtqFLp5FBi51TiD/bG9Dz5FYZ4PO4y2VDNRECohq2XH2Lt g3YBLkxzOl/ioj37YKCCDyAfJIjBtMJyieOKG2IR0BscngS3d3NpctK2jB3KaOEu J9NUTAllXm1poVzP8UhQIh7e5meqEVxOr0bu+CNqWdgcdB5MVq35mRI1uLE/SK07 9Pi+r2Uerrl4ljaUgUjGG3Gk/soDr1lnZPAHqCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517178784; bh=7TaAUX g6Egoe10EuOnPEfBX52jKvsUsyX9hupzLZ1G8=; b=JiuugzTYGS1O4oV5iOhrol osU3BmfM6LTc9s/9BqyEmqv/FbUMKSxMYP1LD4hQ9qtr0hS4Um1psLuGrryP+/uS cs97l9hMw/7sIMbKloV9gYZDg6/VbgAEdeRJZdZJNLjOQ3CB87IxJztjrsAebs+O dVPtjd5ovWUTQaUlYEfRufym3GBBSVp9k8lalU/oGqvLe4xlHObrZhYriz4z3dCQ eon2CxYmPAoMoPvX0zlNPvwB4FgYcSTUn/3gGUBWnmLLul9NaWvKgxWQMffX0+FZ 0SppihZe8tIrdvhaQDCZp2s3UQ/rncoUYTkcwQ1yGOvCoRQ6xsigYP/LPLrDey6A == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=i+CTlh2o x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=i+CTlh2o x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932393AbeA1WdD (ORCPT ); Sun, 28 Jan 2018 17:33:03 -0500 Received: from mail-cys01nam02on0129.outbound.protection.outlook.com ([104.47.37.129]:29515 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932647AbeA1Wal (ORCPT ); Sun, 28 Jan 2018 17:30:41 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Takuo Koguchi , Takuo Koguchi , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 19/25] spi: sun4i: disable clocks in the remove function Thread-Topic: [PATCH AUTOSEL for 3.18 19/25] spi: sun4i: disable clocks in the remove function Thread-Index: AQHTmIeG65hmX4l510qiB6aP9fae9g== Date: Sun, 28 Jan 2018 22:29:57 +0000 Message-ID: <20180128222931.7781-19-alexander.levin@microsoft.com> References: <20180128222931.7781-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222931.7781-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1098;7:wL2McVUdXYDP5hFwAlI1nqB5RL0c7GyaBaLGN5Z4KGApCDfQ+5ttBxl5Y5lB2EkYbB6qd6hnKGbwdoN/wSgsfc2NGJnTGTuOIObAU9fCfNC2Y3ZL/RHq+DlCY0VkqDuc37pzoSgbLM6pt8faJ5j3L8eeODFQFptC2x2IgU0SzXCtoU0cLdgArPYv5TiQHsx8PiZ6er4dzXSTzJ61YZ7cC7FVtgcBHgooowoimDq68VVZs9WwX8S/+jrSfDD5OCPS x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ebdd010f-a8d2-455d-a338-08d5669ec031 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(58145275503218); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1098;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(6666003)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(59450400001)(25786009)(107886003)(5250100002)(8676002)(110136005)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(575784001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(39060400002)(76176011)(6512007)(6486002)(186003)(22906009)(32563001)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1098;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: Q1paK6j+IXCLjLYOSsGaCPUsz0odrhpQlupskFYlpXFj8gxK3IxiFV4RPuEJ6UcKKPPU1gr/FU8d+2Ddsl7klg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebdd010f-a8d2-455d-a338-08d5669ec031 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:29:57.2494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Takuo Koguchi [ Upstream commit c810daba0ab5226084a56893a789af427a801146 ] mclk and hclk need to be disabled. Since pm_runtime_disable does not disable the clocks, use pm_runtime_force_suspend instead. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index 19169bf9bf4d..510f7d8d9a6a 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -458,7 +458,7 @@ static int sun4i_spi_probe(struct platform_device *pdev= ) =20 static int sun4i_spi_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); + pm_runtime_force_suspend(&pdev->dev); =20 return 0; } --=20 2.11.0