From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517179014-2-7735405916196907639 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179013; b=PtsMY64PLrOOTp/zUE3GC680F9DvDtzEIiKS4azgXF8HI3e TaadCo0+iotK/GkkJVrpnQpLidvPw+nfOmHmQ4pi0W7A9aH1dSovIU0mmqRiTmwU iniYLfCv7T3ZZgevmPc/DM0856LXmRu6OgX/EIt6Wr3hOhazVowbhOdZIvRWXB8p TgBvS4Vo94441YXGjzZ4U0KBkodfA4zdgfcfQdfEOjudTI2OfLdBPErxy9Mq7480 FC6zb6uJx1X7CyTmpon0Qqk42qOMd5Ly6ipDSSYSplYAd3ifTty95f6mayVSTBXF E/8/vscHnTbiyuDfqqolgmZwI6a8dtDTR4V29Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179013; bh=AAxNZ2 UlSUuJaAiKuW/18VYd/VaVlohFsrhXLffqiqw=; b=sj33G6s5uRgFk/uUhKavik knFEPbeZGvrM7UyTpiimRP5HZJnNsCMJe5j+d5RZ4yKL9igDvJVeMluUb4LGddPz cuPVlptsBLk9rLgT5eBfY1GRpaVacccYwjZETbmwPCsXkH3chz94FdayQvfEzbDH /Bc1v14xcKN4WxlXC706hhzxBpSDS2ci05NaO1Lh9KYpmOGGaEJsPPYun3fLBXEk Ddo+tE23TLGXouLCFnTwKutuMz2K96oCMtM14EfdIRvaiUkBGdJ4cPV3tJ7l4/gH BlNLrxtjjz10pcgzGL3WrNr0sZSZGM2P5nke7nLbo/vT0Y4nql3Wb/L2dp4Fm1Rg == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=H7TypUUM x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=H7TypUUM x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbeA1Wgi (ORCPT ); Sun, 28 Jan 2018 17:36:38 -0500 Received: from mail-by2nam03on0092.outbound.protection.outlook.com ([104.47.42.92]:41884 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932605AbeA1Wab (ORCPT ); Sun, 28 Jan 2018 17:30:31 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Keerthy , Tony Lindgren , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 02/25] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Thread-Topic: [PATCH AUTOSEL for 3.18 02/25] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Thread-Index: AQHTmId9crtzdVbOFk+XZTSuI35+/w== Date: Sun, 28 Jan 2018 22:29:41 +0000 Message-ID: <20180128222931.7781-2-alexander.levin@microsoft.com> References: <20180128222931.7781-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222931.7781-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1114;7:9DbTLlDAry6C4sk6mXtufigmu3AaxwgBKs4v3GqAdIRxSVykypxqAoXBMN3MdE39Y94224PrxZBDVuEGac3oTKpL70gc41gDgqPAkXufSPcxgbkSRT5piitkN8s8t3COSxW57Xtuu6lIjpzzQ06G9sw7Vi98rg+WtLXjVcp35YG1qXUIHgIm9K527xtjKXpwYwxgZtncQTu0lNjQPyOBPuKzfk1SFt3UQ5ttw3lI0FYaEGSr+dJ05nixYQC9IARy x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7e40a1e4-223a-4a83-1f04-08d5669ebb3c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1114; x-ms-traffictypediagnostic: MW2PR2101MB1114: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(31051911155226)(89211679590171)(106291317490208); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1114;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1114; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(39380400002)(39860400002)(346002)(366004)(189003)(199004)(305945005)(186003)(110136005)(26005)(81156014)(7736002)(8936002)(6506007)(102836004)(81166006)(6116002)(3846002)(316002)(1076002)(6486002)(6436002)(105586002)(22452003)(15760500003)(72206003)(3660700001)(2950100002)(14454004)(966005)(107886003)(6666003)(10290500003)(99286004)(68736007)(2906002)(97736004)(478600001)(3280700002)(76176011)(8676002)(54906003)(86612001)(10090500001)(36756003)(575784001)(86362001)(2900100001)(5660300001)(25786009)(4326008)(5250100002)(6512007)(6306002)(53936002)(106356001)(2501003)(66066001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1114;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: 863VU3BcuZ/sVKQCC3SJ6HomdWXWtbLN0P8pP5zGvyQ8i1Nc570x0ppduA50WlgMZ6nEKcle7Y0Lrk0tpVUp+g== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e40a1e4-223a-4a83-1f04-08d5669ebb3c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:29:41.3741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1114 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Keerthy [ Upstream commit b6d6af7226465b6d11eac09d0be2ab78a4a9eb62 ] Referring TRM Am335X series: http://www.ti.com/lit/ug/spruh73p/spruh73p.pdf The LastPowerStateEntered bitfield is present only for PM_CEFUSE domain. This is not present in any of the other power domains. Hence remove the generic am33xx_pwrdm_read_prev_pwrst hook which wrongly reads the reserved bit fields for all the other power domains. Reading the reserved bits leads to wrongly interpreting the low power transitions for various power domains that do not have the LastPowerStateEntered field. The pm debug counters values are wrong currently as we are incrementing them based on the reserved bits. Signed-off-by: Keerthy Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/prm33xx.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm/mach-omap2/prm33xx.c b/arch/arm/mach-omap2/prm33xx.c index 62709cd2f9c5..1b774985997e 100644 --- a/arch/arm/mach-omap2/prm33xx.c +++ b/arch/arm/mach-omap2/prm33xx.c @@ -165,17 +165,6 @@ static int am33xx_pwrdm_read_pwrst(struct powerdomain = *pwrdm) return v; } =20 -static int am33xx_pwrdm_read_prev_pwrst(struct powerdomain *pwrdm) -{ - u32 v; - - v =3D am33xx_prm_read_reg(pwrdm->prcm_offs, pwrdm->pwrstst_offs); - v &=3D AM33XX_LASTPOWERSTATEENTERED_MASK; - v >>=3D AM33XX_LASTPOWERSTATEENTERED_SHIFT; - - return v; -} - static int am33xx_pwrdm_set_lowpwrstchange(struct powerdomain *pwrdm) { am33xx_prm_rmw_reg_bits(AM33XX_LOWPOWERSTATECHANGE_MASK, @@ -329,7 +318,6 @@ struct pwrdm_ops am33xx_pwrdm_operations =3D { .pwrdm_set_next_pwrst =3D am33xx_pwrdm_set_next_pwrst, .pwrdm_read_next_pwrst =3D am33xx_pwrdm_read_next_pwrst, .pwrdm_read_pwrst =3D am33xx_pwrdm_read_pwrst, - .pwrdm_read_prev_pwrst =3D am33xx_pwrdm_read_prev_pwrst, .pwrdm_set_logic_retst =3D am33xx_pwrdm_set_logic_retst, .pwrdm_read_logic_pwrst =3D am33xx_pwrdm_read_logic_pwrst, .pwrdm_read_logic_retst =3D am33xx_pwrdm_read_logic_retst, --=20 2.11.0