From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517178766-2-17144425914400444842 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517178765; b=vaCONGLq97NTnKpszTLzySnUflFxwNhxp0kw92PDTr7R3kW KvDOU+Jq3BJfE0pnpHEju3UmWQ08kivD+6PIXhItjdSZtyJFdiRC19iG5UvPdcAE KWgQkD4fU029FFSnA5QE30fXqo9zNslHM2Xvx694/oaNe5jgUhP2YFLhmLaA+uU7 T84ByCGRSdytvLlYXYkTj8T9YBE4Vc9sOHcTHLO9arTFYITRv95rUMKwOVP6OJyW 2yYZgQ5czarlEpqWi9BRNY2MAZXpy14xlwpAyzOE/REKjIHK4Gsj5YEOG7qB5bZS ReYwgu3tqNN/F/M1Jq03zDss+nl51aX/f2tzpgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517178765; bh=q7Svr6 IdCeeJKLm9KBEvUHCd7GBySFc6r4m2it8NOzQ=; b=i/vbC8+jU72E4MPW/bteTG ps9kXJnN2L70zOCu9mjO6JFt/U8qEL/t519rinSkOeZ8zYzS0V+VCuMu8n5sYfeV vA2eadMpGN+jCoufevRALzEfkDqtntcZ76v0vpAGK7XBJ7U9gqNig8JS101UD+b1 OnlQjAMGo34qVsSgFUtEuOsiZwaRLWQlgvwgyGd4ZnVAJToDOCHbI4kZxkgfPcpC oG11X3UL3l14vZiHADmW8X24ZnQQzGUyBTKGGwK5BZQNhw2XsErdGkz1tQ8mix2g gx4plluJq+FsIdpvMfi4joHzdfcbCcW2hslFjx/eFZrxzHoSJ+UZ657DJdL1GV9Q == ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Y3yiMSdu x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Y3yiMSdu x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932755AbeA1WcI (ORCPT ); Sun, 28 Jan 2018 17:32:08 -0500 Received: from mail-cys01nam02on0129.outbound.protection.outlook.com ([104.47.37.129]:29515 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932659AbeA1Wam (ORCPT ); Sun, 28 Jan 2018 17:30:42 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Tobias Jordan , Vinod Koul , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 21/25] dmaengine: jz4740: disable/unprepare clk if probe fails Thread-Topic: [PATCH AUTOSEL for 3.18 21/25] dmaengine: jz4740: disable/unprepare clk if probe fails Thread-Index: AQHTmIeHQFEC0jP6L0iiX7haQS04XA== Date: Sun, 28 Jan 2018 22:29:58 +0000 Message-ID: <20180128222931.7781-21-alexander.levin@microsoft.com> References: <20180128222931.7781-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222931.7781-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1098;7:s6xIcohha2Y7bIVpkRUGn2NK8g9XqL2AOVDwN7pJv+XPWaF/GWJxiLBlCkR7bQjw4fIMQK61SXi8PqyjaA8jlduU5ivLJ5ONQqwpW1nn5lvpn9YVbj/FERIB9qL9oK8VRdr99lmeMDK7QI84pb5S4/WdDpqgpwvHTwBnglRBucF2CTgML6hsNkE+XoJOMwqrPSu10oSnj9C60cMwr6WlEZUwfsXK9FHreHSLAr0Mdkj0qA06kYEjflhKUVIIzpPB x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 94df56b8-35b4-4b3c-49d3-08d5669ec09d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1098;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(6666003)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(59450400001)(25786009)(107886003)(5250100002)(8676002)(110136005)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(76176011)(6512007)(6486002)(186003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1098;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: vmpPA84xYNjL/0SDZke7Rqwbjp2ihxS8ejpHKUhu6lx45FU2uCY9jENr++4r1iflOAntT+qCCjxuCKE8C7APdQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94df56b8-35b4-4b3c-49d3-08d5669ec09d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:29:58.8855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Tobias Jordan [ Upstream commit eb9436966fdc84cebdf222952a99898ab46d9bb0 ] in error path of jz4740_dma_probe(), call clk_disable_unprepare() to clean up. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 25ce6c35fea0 MIPS: jz4740: Remove custom DMA API Signed-off-by: Tobias Jordan Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/dma-jz4740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c index ae2ab14e64b3..a2a9726a6871 100644 --- a/drivers/dma/dma-jz4740.c +++ b/drivers/dma/dma-jz4740.c @@ -575,7 +575,7 @@ static int jz4740_dma_probe(struct platform_device *pde= v) =20 ret =3D dma_async_device_register(dd); if (ret) - return ret; + goto err_clk; =20 irq =3D platform_get_irq(pdev, 0); ret =3D request_irq(irq, jz4740_dma_irq, 0, dev_name(&pdev->dev), dmadev)= ; @@ -588,6 +588,8 @@ static int jz4740_dma_probe(struct platform_device *pde= v) =20 err_unregister: dma_async_device_unregister(dd); +err_clk: + clk_disable_unprepare(dmadev->clk); return ret; } =20 --=20 2.11.0