From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517178989-2-1288358931196722140 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES roen, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517178988; b=Ko2uszAJ/q2e0KhMpmX79WgLQaw5NZNhys+YGZp8aQCE8Gi qAB3yaue2SPkL83UEDn2y3INMaX5kwWjOF7KynPHLWic10kTgxV7y4kTBGzTTM1h g36FOvNnSFhgYpnTp8J6r+tr/n4/gs4qEhbkBH9jILz3NS8hfLK/+hJV9DM2ev1+ bHxpoqoyhUc0voxCPZIFllEvrmRhCSwcaSI7xaWN3U0zgIb0fzuYieTZiqHoNSKS hr/R817BjJYLw+LoZwmMX8GXlcrrReeXvMSVvaaGTwRXOXS1xPoYptYGM/+MVp2U opKAAYlmpRIHq/f8X+nE8InGzJ50aMraDsDNG6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517178988; bh=WKqfDF wx590ReD71TLTcj0M5iU2SV5DC9huqFPGmxkU=; b=R14JWjgRaTNah2q2fLW5cN 1ql3TLJZQERHIQM1QggZjPPx8Vdy/8GHfpe099bxP3nYEACJ1vsnfTT/gucP5MWP eW+TRv73FxaUWlYyIOMO6cvd0MJPuWlMjqdwZ5F9gn7bVuNqyfSrE6Mc2Zyh8leY a712maG1IDh4myBmW8VdXncWLmiQGe46649YJMT/HQMuTe29OTnz4qx6quHrX84s iUPL5vsEkDo9K882iGUXRrm0e+4Sjoo53BLeYeL6hNl5B8KWb3dFDwwAHbg5Q4ot JYMXYQ5r6u1CRDuM2MIYcs5aPBM+9p3RnEFZwL9fkeoJoogzJdAZBEsy91+GhhjQ == ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=otapqQ+1 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=otapqQ+1 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932810AbeA1WgB (ORCPT ); Sun, 28 Jan 2018 17:36:01 -0500 Received: from mail-bl2nam02on0093.outbound.protection.outlook.com ([104.47.38.93]:45074 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932611AbeA1Wac (ORCPT ); Sun, 28 Jan 2018 17:30:32 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Satheesh Rajendran , Balamuruhan S , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 05/25] perf bench numa: Fixup discontiguous/sparse numa nodes Thread-Topic: [PATCH AUTOSEL for 3.18 05/25] perf bench numa: Fixup discontiguous/sparse numa nodes Thread-Index: AQHTmId/LL0og12NjkONjxH95Va+Qw== Date: Sun, 28 Jan 2018 22:29:44 +0000 Message-ID: <20180128222931.7781-5-alexander.levin@microsoft.com> References: <20180128222931.7781-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222931.7781-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1098;7:74fa78Y2DTuMN13GPrX8i118pAkvsBqU7tOKf2uoO7Z7vRCw1xAtOXFIChr+0rjYFe64lhfKeFROoUgojzt/vk3AVQpdA0gjjioP4sE31/jI98OIdIMcGbkCKXvKW9oSPawSKfl0f+o9C0mDeMVBXsEwKiHs6WL/BiyBbeyuXw4eBJBxtnQ1z8/zWhwsLbnJ5DE3hsd6PWZ7p+Uk05Vo3BzbytN/BDsQgEnd7XosRIFXA5qz3WzRs+Lq5h009I9q x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 50b3cd5d-7961-4d49-f3d3-08d5669ebbf5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(42068640409301)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1098;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(966005)(6666003)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(25786009)(107886003)(5250100002)(8676002)(110136005)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6306002)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(76176011)(6512007)(6486002)(186003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1098;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: IClKa57Sd/oThzfZEUgjUHrN0ABCexpQtV6aMzt2aApMx7sLR4auZOx+NdBubyhZmRIiwCmKLB7WnVStOlW/1Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50b3cd5d-7961-4d49-f3d3-08d5669ebbf5 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:29:44.3402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Satheesh Rajendran [ Upstream commit 321a7c35c90cc834851ceda18a8ee18f1d032b92 ] Certain systems are designed to have sparse/discontiguous nodes. On such systems, 'perf bench numa' hangs, shows wrong number of nodes and shows values for non-existent nodes. Handle this by only taking nodes that are exposed by kernel to userspace. Signed-off-by: Satheesh Rajendran Reviewed-by: Srikar Dronamraju Acked-by: Naveen N. Rao Link: http://lkml.kernel.org/r/1edbcd353c009e109e93d78f2f46381930c340fe.151= 1368645.git.sathnaga@linux.vnet.ibm.com Signed-off-by: Balamuruhan S Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/bench/numa.c | 56 ++++++++++++++++++++++++++++++++++++++++++++-= ---- 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c index ebfa163b80b5..90d416ba7647 100644 --- a/tools/perf/bench/numa.c +++ b/tools/perf/bench/numa.c @@ -203,6 +203,47 @@ static const char * const numa_usage[] =3D { NULL }; =20 +/* + * To get number of numa nodes present. + */ +static int nr_numa_nodes(void) +{ + int i, nr_nodes =3D 0; + + for (i =3D 0; i < g->p.nr_nodes; i++) { + if (numa_bitmask_isbitset(numa_nodes_ptr, i)) + nr_nodes++; + } + + return nr_nodes; +} + +/* + * To check if given numa node is present. + */ +static int is_node_present(int node) +{ + return numa_bitmask_isbitset(numa_nodes_ptr, node); +} + +/* + * To check given numa node has cpus. + */ +static bool node_has_cpus(int node) +{ + struct bitmask *cpu =3D numa_allocate_cpumask(); + unsigned int i; + + if (cpu && !numa_node_to_cpus(node, cpu)) { + for (i =3D 0; i < cpu->size; i++) { + if (numa_bitmask_isbitset(cpu, i)) + return true; + } + } + + return false; /* lets fall back to nocpus safely */ +} + static cpu_set_t bind_to_cpu(int target_cpu) { cpu_set_t orig_mask, mask; @@ -231,12 +272,12 @@ static cpu_set_t bind_to_cpu(int target_cpu) =20 static cpu_set_t bind_to_node(int target_node) { - int cpus_per_node =3D g->p.nr_cpus/g->p.nr_nodes; + int cpus_per_node =3D g->p.nr_cpus / nr_numa_nodes(); cpu_set_t orig_mask, mask; int cpu; int ret; =20 - BUG_ON(cpus_per_node*g->p.nr_nodes !=3D g->p.nr_cpus); + BUG_ON(cpus_per_node * nr_numa_nodes() !=3D g->p.nr_cpus); BUG_ON(!cpus_per_node); =20 ret =3D sched_getaffinity(0, sizeof(orig_mask), &orig_mask); @@ -636,7 +677,7 @@ static int parse_setup_node_list(void) int i; =20 for (i =3D 0; i < mul; i++) { - if (t >=3D g->p.nr_tasks) { + if (t >=3D g->p.nr_tasks || !node_has_cpus(bind_node)) { printf("\n# NOTE: ignoring bind NODEs starting at NODE#%d\n", bind_no= de); goto out; } @@ -943,6 +984,8 @@ static void calc_convergence(double runtime_ns_max, dou= ble *convergence) sum =3D 0; =20 for (node =3D 0; node < g->p.nr_nodes; node++) { + if (!is_node_present(node)) + continue; nr =3D nodes[node]; nr_min =3D min(nr, nr_min); nr_max =3D max(nr, nr_max); @@ -963,8 +1006,11 @@ static void calc_convergence(double runtime_ns_max, d= ouble *convergence) process_groups =3D 0; =20 for (node =3D 0; node < g->p.nr_nodes; node++) { - int processes =3D count_node_processes(node); + int processes; =20 + if (!is_node_present(node)) + continue; + processes =3D count_node_processes(node); nr =3D nodes[node]; tprintf(" %2d/%-2d", nr, processes); =20 @@ -1262,7 +1308,7 @@ static void print_summary(void) =20 printf("\n ###\n"); printf(" # %d %s will execute (on %d nodes, %d CPUs):\n", - g->p.nr_tasks, g->p.nr_tasks =3D=3D 1 ? "task" : "tasks", g->p.nr_nodes,= g->p.nr_cpus); + g->p.nr_tasks, g->p.nr_tasks =3D=3D 1 ? "task" : "tasks", nr_numa_nodes(= ), g->p.nr_cpus); printf(" # %5dx %5ldMB global shared mem operations\n", g->p.nr_loops, g->p.bytes_global/1024/1024); printf(" # %5dx %5ldMB process shared mem operations\n", --=20 2.11.0