From: Willy Tarreau <w@1wt.eu>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: miguel.ojeda.sandonis@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep
Date: Mon, 29 Jan 2018 07:50:53 +0100 [thread overview]
Message-ID: <20180129065053.GC20230@1wt.eu> (raw)
In-Reply-To: <1516979955-7466-1-git-send-email-baijiaju1990@gmail.com>
Hi,
On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote:
> The function long_sleep() calls mdelay() when in an interrupt handler.
> But only charlcd_clear_display() and charlcd_init_display calls
> long_sleep(), and my tool finds that the two functions
> are never called in an interrupt handler.
> Thus mdelay() and in_interrupt() are not necessary.
>
> This is found by a static analysis tool named DCNS written by myself.
Looks good. This code is extremely old (started in 2.2) so I'm not
surprised at all that after many changes such parts are not used
anymore.
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2018-01-29 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 15:19 [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep Jia-Ju Bai
2018-01-29 6:50 ` Willy Tarreau [this message]
2018-02-12 12:00 ` Miguel Ojeda
2018-02-12 13:26 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129065053.GC20230@1wt.eu \
--to=w@1wt.eu \
--cc=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox