From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbeA2Gu5 (ORCPT ); Mon, 29 Jan 2018 01:50:57 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:40193 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbeA2Gu4 (ORCPT ); Mon, 29 Jan 2018 01:50:56 -0500 Date: Mon, 29 Jan 2018 07:50:53 +0100 From: Willy Tarreau To: Jia-Ju Bai Cc: miguel.ojeda.sandonis@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep Message-ID: <20180129065053.GC20230@1wt.eu> References: <1516979955-7466-1-git-send-email-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516979955-7466-1-git-send-email-baijiaju1990@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote: > The function long_sleep() calls mdelay() when in an interrupt handler. > But only charlcd_clear_display() and charlcd_init_display calls > long_sleep(), and my tool finds that the two functions > are never called in an interrupt handler. > Thus mdelay() and in_interrupt() are not necessary. > > This is found by a static analysis tool named DCNS written by myself. Looks good. This code is extremely old (started in 2.2) so I'm not surprised at all that after many changes such parts are not used anymore. Acked-by: Willy Tarreau Willy