From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751363AbeA2HSO (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Jan 2018 02:18:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57734 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751042AbeA2HSN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Jan 2018 02:18:13 -0500
Date: Mon, 29 Jan 2018 08:18:10 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/2] tools lib symbol: Use strtoul instead of hex2u64 in
 kallsyms__parse
Message-ID: <20180129071810.GA5774@krava>
References: <20180119161103.15035-1-jolsa@kernel.org>
 <20180119161103.15035-2-jolsa@kernel.org>
 <CAHp75Vd7A8JdTR_oiKrG5VOabkMKNRiD4c560DRqRzZn=oDPGA@mail.gmail.com>
 <CAHp75VdQqEOK+RGJ7HRm+2k8RBzzfJbZeB-zVa4jNgj_YJywcw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VdQqEOK+RGJ7HRm+2k8RBzzfJbZeB-zVa4jNgj_YJywcw@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 26, 2018 at 07:27:06PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 26, 2018 at 7:22 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Jan 19, 2018 at 6:11 PM, Jiri Olsa <jolsa@kernel.org> wrote:
> >> Current kallsyms__parse uses hex2u64, which gives
> >> no indication of error. Using strtoul to checkup
> >> on failed attempt to parse the number and stop the
> >> rest of the kallsyms__parse processing early.
> >
> >> +               start = strtoul(line, &endptr, 16);
> >> +               if (line == endptr)
> >> +                       continue;
> >> +
> >> +               len = endptr - line + 1;
> >>
> >> -               len++;
> >>                 if (len + 2 >= line_len)
> >>                         continue;
> >
> > https://patchwork.kernel.org/patch/4087681/
> 
> Even second attempt including recent ping left without consideration.
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1407.0/02791.html

I see, sry we overlooked it.. could you please repost it?

thanks,
jirka