From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751621AbeA2Im0 (ORCPT ); Mon, 29 Jan 2018 03:42:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:22277 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbeA2ImY (ORCPT ); Mon, 29 Jan 2018 03:42:24 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="199585035" Date: Mon, 29 Jan 2018 10:42:21 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Tomas Winkler , Alexander Usyskin , tpmdd-devel@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] tpm: separate cmd_ready/go_idle from runtime_pm Message-ID: <20180129084221.deudcqbsh22hcrrb@linux.intel.com> References: <20180123112731.3687-1-tomas.winkler@intel.com> <20180123112731.3687-2-tomas.winkler@intel.com> <20180123130841.ub2amxalgr2oapu6@linux.intel.com> <20180123153322.GB30670@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123153322.GB30670@ziepe.ca> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 23, 2018 at 08:33:22AM -0700, Jason Gunthorpe wrote: > On Tue, Jan 23, 2018 at 03:08:41PM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 23, 2018 at 01:27:30PM +0200, Tomas Winkler wrote: > > > We cannot use go_idle cmd_ready commands via runtime_pm handles > > > as with the introduction of localities this is no longer an optional > > > feature, while runtime pm can be not enabled. > > > Though cmd_ready/go_idle provides power saving feature, it's also part of > > > TPM2 protocol and should be called explicitly. > > > This patch exposes cmd_read/go_idle via tpm class ops and removes > > > runtime pm support as it is not used by any driver. > > > > > > Signed-off-by: Tomas Winkler > > > > Thank you. > > > > LGTM > > > > Jason, what do you think? > > The PM stuff has been the source of confusion for a while, seems > reasonable to get rid of it. I'll test this ASAP. /Jarkk