From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224hJxwxj1Oen3XWFFuT4yK4vCPnq3+7J8MPoJ8zSl2X1aKvLPvoO7UhoUjHyoTFWEIrtSNW ARC-Seal: i=1; a=rsa-sha256; t=1517256304; cv=none; d=google.com; s=arc-20160816; b=cIfMRyqpKpNu2QreoQbiFP7sFOY8eRZPmd/2OBgGPywSjzuseDjp9g8bbu7i+Rw7nU bNFO+XIWXYZNYHnSB7mDcjN1pfLRWgzRMnm/eJU5RDEQx6pmP3eeHr1M2FHdomm+009F nJIpz1HHDPwp7hlu0AupyA4F43dhouDPNhQBdYFKb/LB+WCwNJzASMbBzu6Uom2UhFAp j13pWlDJyfSanjGPH4R9KE/zGNSDDsQTaTdfJukcq+2aeMp7DwdjpAnnagqaBTF+NTEy otvC0IBkqH/oZcZ6rBDu6aGZBv6JisGxI+XjQKGmyzZSxsn20HJYyCuwB2I66JoDCGn4 p7eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=6vfmejDOYL1JN8Zje5+TfwXo4/6heTDZNeURcxzWEx0=; b=cimZIHAj3QKJ/DJ+aOvn99qrHeOs75TNND4iasvChQFrnEHlIjyI2gM/YaMNlmvVQc r7gCJ+9SNIMzVRrHCFULi3UCRM0j/U+gyFKkMeKoG5qI8ZCaUImiMtnS4ZsEp9R2uzGB WpXrTCAxB5ajVFiRjk/IfARtViaPWEMaVHbjvnY+Z0JRtcVa325pgfezcdA24a3xTWMd bQ9JFQlpLsuG7XJtnIsRMZrDtYpxTD1JYi3zDx6x1YU0n+T9w2TYQewl3Rx0gGImmteN Pvb5/zPONlIs1DmlWU6b6HMASRB784FagkGaJemcCSPDayZsla1C2QXyxAsH/1WLL1E0 uSbA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Dmitry Torokhov Subject: [PATCH 3.18 13/52] Input: twl4030-vibra - fix sibling-node lookup Date: Mon, 29 Jan 2018 13:56:31 +0100 Message-Id: <20180129123628.767799173@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123628.168904217@linuxfoundation.org> References: <20180129123628.168904217@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958546685537507?= X-GMAIL-MSGID: =?utf-8?q?1590958546685537507?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 5b189201993ab03001a398de731045bfea90c689 upstream. A helper purported to look up a child node based on its name was using the wrong of-helper and ended up prematurely freeing the parent of-node while searching the whole device tree depth-first starting at the parent node. Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel") Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning") Signed-off-by: Johan Hovold Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/twl4030-vibra.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/input/misc/twl4030-vibra.c +++ b/drivers/input/misc/twl4030-vibra.c @@ -180,12 +180,14 @@ static SIMPLE_DEV_PM_OPS(twl4030_vibra_p twl4030_vibra_suspend, twl4030_vibra_resume); static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata, - struct device_node *node) + struct device_node *parent) { + struct device_node *node; + if (pdata && pdata->coexist) return true; - node = of_find_node_by_name(node, "codec"); + node = of_get_child_by_name(parent, "codec"); if (node) { of_node_put(node); return true;