From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225PZ/b83GCQgcNRpGDmc51o0UcN9Pp7o0IZ7JFm/2eTNauqqD18Gmf667ULnkSw9NVIWaa6 ARC-Seal: i=1; a=rsa-sha256; t=1517256491; cv=none; d=google.com; s=arc-20160816; b=p/HlQ8NYzr8TDpZF/uw5EwOQ9YB2rzjtQE5ty2dMGsXM0tVf008yLbXKew6zQTbi3N MZq6Kcdu7nNomZpRWJhWCq1tLiXyCPneigNvFL9NB6xHGJkX0dM0RoXEufBYsEo+0/SI U8YlJXuQ6+ky+AJg+t3Mtd820av3Uc9rEJK8ocOveRG2VCbIVGqafYt9sq2gt2lYCIuv EeFA6vrpMbQdofxgUBPI8dsygdvPweB+LWyZeoKaGdn2xanqL6gPsNagmNCBRI5Ob1y5 GKAcPbi6+p/UfiG2cY2wVPo9bsk3jXy3v/ANvLINv3uwRQ/9b5aOOrrR40cUjEFF9S8W y71g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=LfkJ3sH9pTKCPBWWBvB2zQEZ9ZR2H/sMf8HqQEDEU7w=; b=f8yQ8F9mq/CcMAtjbhAWgdSkPAVTOfXCSj8wTrccyqSk8KM26z6Iffm15wZoq+d1ej KD/JzZpwuOIMj0cZS+Tn0woo8vXLKVN4ttzlIBhFACcIpBYyjoHSu/Md9ub+zUz77Mxe 52fIreVAldi2/Tv8kzVaPEm6XHtuyyE2PvktPaO6oQG+wkAv700aYuXrKFzXhmPQUogG +6mCC0v6A87g4rkB5AEGT/zJeutl6Hg5ZfsXYmhDUvXzs/lIY2YlFBUfr0M9tmYy5wdV RV+JlOZmlXRRNbzK+xpTsJL5R1nH/oKNE0/49q+dXQAxm1GpdxH6GZx20dOlRVN/IzML 2acQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Russell King Subject: [PATCH 4.14 21/71] ARM: net: bpf: clarify tail_call index Date: Mon, 29 Jan 2018 13:56:49 +0100 Message-Id: <20180129123828.726153352@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958742942537009?= X-GMAIL-MSGID: =?utf-8?q?1590958742942537009?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Russell King commit 091f02483df7b56615b524491f404e574c5e0668 upstream. As per 90caccdd8cc0 ("bpf: fix bpf_tail_call() x64 JIT"), the index used for array lookup is defined to be 32-bit wide. Update a misleading comment that suggests it is 64-bit wide. Fixes: 39c13c204bb1 ("arm: eBPF JIT compiler") Signed-off-by: Russell King Signed-off-by: Greg Kroah-Hartman --- arch/arm/net/bpf_jit_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c @@ -1016,7 +1016,7 @@ static int emit_bpf_tail_call(struct jit emit_a32_mov_i(tmp[1], off, false, ctx); emit(ARM_LDR_I(tmp2[1], ARM_SP, STACK_VAR(r2[1])), ctx); emit(ARM_LDR_R(tmp[1], tmp2[1], tmp[1]), ctx); - /* index (64 bit) */ + /* index is 32-bit for arrays */ emit(ARM_LDR_I(tmp2[1], ARM_SP, STACK_VAR(r3[1])), ctx); /* index >= array->map.max_entries */ emit(ARM_CMP_R(tmp2[1], tmp[1]), ctx);