From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225MS7zUgLXUfwrU9gB4d9yq06NYm/weTyh0g0QdotI9IZBU/OBequtmWe/12arXMHUEbPtL ARC-Seal: i=1; a=rsa-sha256; t=1517256308; cv=none; d=google.com; s=arc-20160816; b=XPRoahbQ2VupYFeapcqjE/f6pZzMeMiAu02dFsOcnFdLFdbfPkgBMSE4tgwEmxFL+2 X+oAIB6x6XNlIZ0+8/5al5acXnz/M40MTUmCDpoJHkI+SjKCNPXHypfkLzH+wv7vlldG fwJCA8LRc43XyCC9I0XyHx6nN5mnR2YbiSyizHpSg1dl/PXZZeUim4gWaJOMfmTiecAl +qYjcs10cE8vM/Z1ld4PA7ewpF/HGBWeqhIaD20jdMLL8wdtGr7pvhAMxOICadQO+wRy AtplDwJdaLgmyulgb0NKr7jo060L5lbY6CwCGzRVb/tpDwJVAm3OiDMyneXt2c3wUstB Zf/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=nCR4+ftnjI1LBDxf+iLGzdGOEyS84le6eXfHuGYguFE=; b=NtdRIoXKuVmB1TP4i8yEgGRBzi+JY+zd9AFMlKswW2N51gI+JDmzvwykFVOaYJP3UK T0lfBXn+wQCaQnWVnWoHIVuVAWBZ8UxjF8mi3vrlFjgtzXKzVXv7g2PHGAC9ge63U7X3 ar1a4rlV3QZlqcUZb7SgVt91hpbnvViDhijYfhC0vj/AVN06cl9mNPSzgyVzsh/Coxn3 zMcjfdOfDK33J9IoCkhtuvHArBNgQe2ATLN4yLAqdgolRybi+wPuGV4lVU4zHGzOAI5l WgXrZBqpbqrsrBu1zTMYPHWB2YvaLsv3x7iNHFytiEK2+n1EufkaIrg8jDKLH5t+ZsyI HuGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sukumar Gopalakrishnan , David Ahern , "David S. Miller" Subject: [PATCH 4.14 34/71] net: vrf: Add support for sends to local broadcast address Date: Mon, 29 Jan 2018 13:57:02 +0100 Message-Id: <20180129123829.527974942@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958551205171307?= X-GMAIL-MSGID: =?utf-8?q?1590958551205171307?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Ahern [ Upstream commit 1e19c4d689dc1e95bafd23ef68fbc0c6b9e05180 ] Sukumar reported that sends to the local broadcast address (255.255.255.255) are broken. Check for the address in vrf driver and do not redirect to the VRF device - similar to multicast packets. With this change sockets can use SO_BINDTODEVICE to specify an egress interface and receive responses. Note: the egress interface can not be a VRF device but needs to be the enslaved device. https://bugzilla.kernel.org/show_bug.cgi?id=198521 Reported-by: Sukumar Gopalakrishnan Signed-off-by: David Ahern Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/vrf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -674,8 +674,9 @@ static struct sk_buff *vrf_ip_out(struct struct sock *sk, struct sk_buff *skb) { - /* don't divert multicast */ - if (ipv4_is_multicast(ip_hdr(skb)->daddr)) + /* don't divert multicast or local broadcast */ + if (ipv4_is_multicast(ip_hdr(skb)->daddr) || + ipv4_is_lbcast(ip_hdr(skb)->daddr)) return skb; if (qdisc_tx_is_default(vrf_dev))