From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227TO3u8p41ThOl23vTFCHvBPaFmsed/cZTXYO6+ptmc6EFf45tK2YhgutRnk2BICVL2yUVS ARC-Seal: i=1; a=rsa-sha256; t=1517256897; cv=none; d=google.com; s=arc-20160816; b=fvmYubQY6jGboJ9J7NNdVF5diXJJsEB5YMyMJZSTP95RxWxltrDGFIEJ8r/yn0l6Yt Nl8/E+VViaOECzUZcODBqB1KQQrvNRADAY9DgjnNyHTQGhS6K3yaWOuSVT8FYJGqqjgD 6ko+hvYQRSXnD5wDQPnc9C15AfhkpLoY05C6tOUT7+jkRcgT0PN9DFNSk3sKXjEZ0TlR T8buHEImbUtVGBPRlctH61V5AWkIwVMK/b0t3o3j8NcehBN5uq3nTsNoC+816nXcnxtX kKApTBswhHhd0OLyM7wqEXaZqdoWEJsH8m01IBLLa1iMpcW3fQwqncY1cDBVlk89VA9G r/8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=hl1CZ3a+CJTFHRMSlDqTtHhE8DRN5Hmc7X9cqeW/xik=; b=Xb8S9/KuEeyAW2obcKb4wBOg/1xbNOzV2sRCxRYnJiRB1dp5/AcUcQTXF9f6xbHJ2Y qCTGmaARiSTORQV4dqvEGld95/H8z62I5I/3gjj4hq3qZ7XDVbQ81f/1A4PdKkwEjyso eyJFfr9OT4u6jPztAEhynGoesEeOpBixjVFAVM+cvd2YWluug2EXlzakXQWXASjMrsE9 QQVZdsnkCJDDoiOjwpRuplcii3FLrmgTGK4mYFU/dAN0uSsBo0FNRH59X105gm2IaMNu JI2SA5YumnyZNDdtBwiqwi7XasFDENx9xGppOd7ScJn8PtQrbw1HzWSus9mSszSlyfbv S4tg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , syzbot , "David S. Miller" Subject: [PATCH 4.9 36/66] ipv6: ip6_make_skb() needs to clear cork.base.dst Date: Mon, 29 Jan 2018 13:57:00 +0100 Message-Id: <20180129123841.790131979@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123839.842860149@linuxfoundation.org> References: <20180129123839.842860149@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958581264208744?= X-GMAIL-MSGID: =?utf-8?q?1590959168296597000?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 95ef498d977bf44ac094778fd448b98af158a3e6 ] In my last patch, I missed fact that cork.base.dst was not initialized in ip6_make_skb() : If ip6_setup_cork() returns an error, we might attempt a dst_release() on some random pointer. Fixes: 862c03ee1deb ("ipv6: fix possible mem leaks in ipv6_make_skb()") Signed-off-by: Eric Dumazet Reported-by: syzbot Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/ip6_output.c | 1 + 1 file changed, 1 insertion(+) --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1800,6 +1800,7 @@ struct sk_buff *ip6_make_skb(struct sock cork.base.flags = 0; cork.base.addr = 0; cork.base.opt = NULL; + cork.base.dst = NULL; v6_cork.opt = NULL; err = ip6_setup_cork(sk, &cork, &v6_cork, ipc6, rt, fl6); if (err) {