From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226R+IS2ZmmYw/OngoAuEkvKbziSGjEAFWZfBbqDLoyoGQw9enWEaE5FL5CjPmgYlnjgonYJ ARC-Seal: i=1; a=rsa-sha256; t=1517256351; cv=none; d=google.com; s=arc-20160816; b=w54QcDdEf+F1X1KeRQeR+f3nhzxviFtHCnSxJPeouHbM0XynS2xhbgKof7t/LkrdVM tqTqlfXXjcU8chj6jJTJ9N7+4cHVnrRhyemahK3YnJtFW0j/nTILxcgKTHUCaDS6i2Vo LTjHI71x4rGnSiYwt3EQTb3L4BJBKFOcufNpztV6yl81n/wbp4LNIw4pQQhW7QeFkFbM YGQRKnRT3X8KAKPtTlPRp1Qzqn0kFfMoOdJHfm8pTYGoWPXFEYKHeM0907ErD0SlXtxQ x9eMEB6y0IfFjSa/vA18G4sqX3lhKsZjVe6VKZPYrUsruzI8wlRimsbJqHIPvyU6ps/J Rz2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=c0pE/Rakd/nb/9S6bOHaXI63pJPUuvHM7XF7QJq/kJQ=; b=YT1UaHcuRzH7ZkKQ1VP80jo7GdGvV+XDOk6T4/udNGiexxp1MP/qWDLgkgnL6BNIvX RnYdg/HFCqn0ROeJZL3mnvQk6P8UUNWKZ6/2xOoBQcAQ/4HkFK0MMJciwKKvkGWQCGYI vj9cadDS/he/p015BJ5wI1jGb2hI81BCOMysQU5jqJo1khu62gX0lU7NtRXfZHdnYkfP P9gwKw5vUwqtYSrYGC03Yb9MRFvGGzqOHcAdTMftE+FfuIDhxIsV5oEER6bKeSzG/Ni+ EZjZqDSxoe6shiFY22GcBKr4lMfWBUHJTM25kZFzYaH1MLUF6AxK4lyUl8o3EzLynaeQ VhWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Ivan Vecera , "David S. Miller" Subject: [PATCH 4.9 50/66] be2net: restore properly promisc mode after queues reconfiguration Date: Mon, 29 Jan 2018 13:57:14 +0100 Message-Id: <20180129123842.526920503@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123839.842860149@linuxfoundation.org> References: <20180129123839.842860149@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958596701478389?= X-GMAIL-MSGID: =?utf-8?q?1590958596701478389?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Vecera [ Upstream commit 52acf06451930eb4cefabd5ecea56e2d46c32f76 ] The commit 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") modified be_update_queues() so the IFACE (HW representation of the netdevice) is destroyed and then re-created. This causes a regression because potential promiscuous mode is not restored properly during be_open() because the driver thinks that the HW has promiscuous mode already enabled. Note that Lancer is not affected by this bug because RX-filter flags are disabled during be_close() for this chipset. Cc: Sathya Perla Cc: Ajit Khaparde Cc: Sriharsha Basavapatna Cc: Somnath Kotur Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") Signed-off-by: Ivan Vecera Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/emulex/benet/be_main.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -4733,6 +4733,15 @@ int be_update_queues(struct be_adapter * be_schedule_worker(adapter); + /* + * The IF was destroyed and re-created. We need to clear + * all promiscuous flags valid for the destroyed IF. + * Without this promisc mode is not restored during + * be_open() because the driver thinks that it is + * already enabled in HW. + */ + adapter->if_flags &= ~BE_IF_FLAGS_ALL_PROMISCUOUS; + if (netif_running(netdev)) status = be_open(netdev);