From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2242qELmpAcwapi1FnGobsH7jq9WwoNL8BgvT4yUSseDvU73NRLqDzDu/rOAmovNT3n9mcmP ARC-Seal: i=1; a=rsa-sha256; t=1517256736; cv=none; d=google.com; s=arc-20160816; b=icj+KDED8aGrzKYiQkXtHn72O66WV3NPgqCKXYeOa9grzYkPM3rpoU273ue7ekz9vM Vm5k9D5ANv+mGIA5Q4ZiJIaZPSkeJIA51+Po+HPH11j7L4skK6UjLxR3gTk2QH14rEYm uv/pGVXCuNU3l4LsfEBCBOrgDDbt95xyXQHGmtNaaQbte9kcFeJSZ8Ogx4ahN5qyjO3L FlCxxQ+gEvIZNJED+DrCFZygAXIzy61+r73ZSjpSQ2c+NSgVIKixFkMUZ6eXric9+4qf PyFCbF05gZkj5+i6V3XFh6i+nv4dJmh7Xx9jI6xfE9Dt5MG0HghZJji9CmjCdRr7svU5 cLgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=iQ3qMWbRivvxgP2W8blWPJ8XzbMHepnzmVT66gzgCgs=; b=UvKfMbkjfUh6a6eBDwBxkIrDfxDXwZgJraATEf2SOX+hLTnWYprN0S3P8KZOEye4nB +F8so57jF73bepCiArLRNnmoKp495HZl3XpU56uMniiFMnvVODmIZW1Tg9HwlQhFWQfB 3CnR56Cw1TJEy9oxKifvYUQwbNsIOXQIk3r6v3kwNg55FaAFc0C0EzivIGXIudaDEBbv 843wSyQ6BjSPlaOO/jyWcS0CKCptaRexf9DhW4dd6MIQZ6vH0GT9VdWla+cAo1KxfLy7 1i2rxJDFcCLsHUPemsTLL95NJiKbSBDobU4sCreb32aDw30cj1t9G8qAhf/OYkxi6qxT yx1g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Biggers , "Rafael J. Wysocki" , Jiri Slaby Subject: [PATCH 4.4 11/74] PM / sleep: declare __tracedata symbols as char[] rather than char Date: Mon, 29 Jan 2018 13:56:16 +0100 Message-Id: <20180129123848.053659089@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123847.507563674@linuxfoundation.org> References: <20180129123847.507563674@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958999876872590?= X-GMAIL-MSGID: =?utf-8?q?1590958999876872590?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Biggers commit f97238373b8662a6d580e204df2e7bcbfa43e27a upstream. Accessing more than one byte from a symbol declared simply 'char' is undefined behavior, as reported by UBSAN: UBSAN: Undefined behaviour in drivers/base/power/trace.c:178:18 load of address ffffffff8203fc78 with insufficient space for an object of type 'char' Avoid this by declaring the symbols as arrays. Signed-off-by: Eric Biggers Signed-off-by: Rafael J. Wysocki Signed-off-by: Jiri Slaby Signed-off-by: Greg Kroah-Hartman --- drivers/base/power/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/base/power/trace.c +++ b/drivers/base/power/trace.c @@ -166,14 +166,14 @@ void generate_pm_trace(const void *trace } EXPORT_SYMBOL(generate_pm_trace); -extern char __tracedata_start, __tracedata_end; +extern char __tracedata_start[], __tracedata_end[]; static int show_file_hash(unsigned int value) { int match; char *tracedata; match = 0; - for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; + for (tracedata = __tracedata_start ; tracedata < __tracedata_end ; tracedata += 2 + sizeof(unsigned long)) { unsigned short lineno = *(unsigned short *)tracedata; const char *file = *(const char **)(tracedata + 2);