From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226f7BuJM6HmK26swOFqcosBXvm24TmLupOZ2NDHTfIszSwQIIr1hRV/FisWLsh+c6IM9Myr ARC-Seal: i=1; a=rsa-sha256; t=1517256800; cv=none; d=google.com; s=arc-20160816; b=e2QeyGryHdXI7vG5l6Ls0nhn+xvDjz/pkIX1FvisV5HXpmpiWZ0zU4wImqZC8JaGE+ /2o+6vF6iito6ooGwXVJztIf5rM+STAji5VDigJyFbfkJ8lZTKZsEtDoruWoWJuyNNmB Y0bd1+8b5X0/Yj2ge/uc9sfE2wQy/ggWC+PYdiQOGt140O7a8cLmb/j/+Ee7xjFQQN9i BOFVT97QBayVUnwrn8yp+N5aBdfiVQdrOt5sOUY48VSKiIRY0SV2qMurCmvYpKCMRCwq GOs+Em+F0xT4fB7lmirkTwrSs0EGLtYd3z0xCfWPb1af5xD85SMFqgBNCsfHXkgfo65r igwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=WrOpDxCh6jbATnNCttN81I3mnG65BuimB5AlOqz6HtQ=; b=aqjHGqVRuvXitPUpiNoYVtYL4ruZf1mlL4JekD7L1RRVqwtPevf+k8A1cq7hysEsRk QfAo7c5DqvfgxnlNFPCJdqy6esrwUrzvOmjEmRa/5jwqtEHiMotOYEGPniPOMn8X3L0n y2LeZPTHWNB6wXCS94Hpg7zV1FwuYxFVXKmhwrf9oYzb80yqWb6/TIrW6RP9EO/EAqDF yAPJRjZvjEsdQ3w3ms07tHG4bpsSRkbmRsvQTW6h3KFHNqa0SKftCcXKbl8QOKKhnQMF FJBLE/ZtGkOcrAU6nsyPqDoHLLv1/mVOO8gSo4qL25iw7JaH+NdOZvYWIA0yg6TuBPFS Bb+g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hongxu Jia , Florian Westphal , Pablo Neira Ayuso , Michal Kubecek Subject: [PATCH 4.4 31/74] netfilter: arp_tables: fix invoking 32bit "iptable -P INPUT ACCEPT" failed in 64bit kernel Date: Mon, 29 Jan 2018 13:56:36 +0100 Message-Id: <20180129123849.005587090@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123847.507563674@linuxfoundation.org> References: <20180129123847.507563674@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590959067268045213?= X-GMAIL-MSGID: =?utf-8?q?1590959067268045213?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hongxu Jia commit 17a49cd549d9dc8707dc9262210166455c612dde upstream. Since 09d9686047db ("netfilter: x_tables: do compat validation via translate_table"), it used compatr structure to assign newinfo structure. In translate_compat_table of ip_tables.c and ip6_tables.c, it used compatr->hook_entry to replace info->hook_entry and compatr->underflow to replace info->underflow, but not do the same replacement in arp_tables.c. It caused invoking 32-bit "arptbale -P INPUT ACCEPT" failed in 64bit kernel. -------------------------------------- root@qemux86-64:~# arptables -P INPUT ACCEPT root@qemux86-64:~# arptables -P INPUT ACCEPT ERROR: Policy for `INPUT' offset 448 != underflow 0 arptables: Incompatible with this kernel -------------------------------------- Fixes: 09d9686047db ("netfilter: x_tables: do compat validation via translate_table") Signed-off-by: Hongxu Jia Acked-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Acked-by: Michal Kubecek Signed-off-by: Greg Kroah-Hartman --- net/ipv4/netfilter/arp_tables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/ipv4/netfilter/arp_tables.c +++ b/net/ipv4/netfilter/arp_tables.c @@ -1339,8 +1339,8 @@ static int translate_compat_table(struct newinfo->number = compatr->num_entries; for (i = 0; i < NF_ARP_NUMHOOKS; i++) { - newinfo->hook_entry[i] = info->hook_entry[i]; - newinfo->underflow[i] = info->underflow[i]; + newinfo->hook_entry[i] = compatr->hook_entry[i]; + newinfo->underflow[i] = compatr->underflow[i]; } entry1 = newinfo->entries; pos = entry1;