From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225laK0Ci1Q8SEtr6fZrnopUXIsxu1NGT0FSlTqZ1hDWFR6Hry33Dpj9MxmlkUkrbv7SDU3r ARC-Seal: i=1; a=rsa-sha256; t=1517256622; cv=none; d=google.com; s=arc-20160816; b=j/IGcYxVl1dFv5r18UMUNXNQBBeu87XlHC3w7/ZB/4mBrj5780ESnTDCCYjjWEqy7W 1gi8rE1gQT7BseLlMaY0i/7Cp2a1iEbIA7cTQZHhOaNGvYDzvvajS0473G5RxqFqyL0c r9YAaiYQCNignwCehBkZFUAeKCMQM5eWT9v30U+ed5oTs0+XZ6a3i8qxVaxngsIbK4HB 7kRE7A0YkmxlHIQtMX6PiJRz26Clrfwv+j/zOZVgFoATSgrR4IqkTnvNo1DyODEaFRO/ pSnXdHi3++52IRzYYuucE632Bz512k8RHib397Y9CbT90Acurd6KLpdXEbRFbQDKcSo9 59gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=wzQXRvnM1bD4+hbRzBEZJxgEhN33Kb9129ETMqsS5HI=; b=VrMkzAMZzzaeIoh2GJLTQQp6ogUABXrNy8XuUizNFk9GviS44mUGm3ZPChWHJkgcVg jfKfIwuO/1ELxVnPMEqQNrBmk6fTI7AL4ht5A6vO3OSm4Ek0OFHr3+jyDBkQBXDNWHwI X93qKGMCRTnO9RHQtvdxOo8bi3Adg9tCYHFMU+oYDPD84plsa+BKToii6R2bTlnsvwcd EZ0IMbc6ooExXC+d3aA4jYB5kr3lOP9AuIjMqGzT55PgortZe/FHLzHfguLE239zX4CU ZmwE9WgwMe8tMDlcMC44c4xf1vatGmEFSAEmhhtHCgKLQgjI/U2XxYqCREirjw/HQkT8 v/PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Thumshirn , Lee Duncan , Hannes Reinecke , Bart Van Assche , Chris Leech , "Martin K. Petersen" Subject: [PATCH 4.4 46/74] scsi: libiscsi: fix shifting of DID_REQUEUE host byte Date: Mon, 29 Jan 2018 13:56:51 +0100 Message-Id: <20180129123849.644256149@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123847.507563674@linuxfoundation.org> References: <20180129123847.507563674@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958879942292736?= X-GMAIL-MSGID: =?utf-8?q?1590958879942292736?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Thumshirn commit eef9ffdf9cd39b2986367bc8395e2772bc1284ba upstream. The SCSI host byte should be shifted left by 16 in order to have scsi_decide_disposition() do the right thing (.i.e. requeue the command). Signed-off-by: Johannes Thumshirn Fixes: 661134ad3765 ("[SCSI] libiscsi, bnx2i: make bound ep check common") Cc: Lee Duncan Cc: Hannes Reinecke Cc: Bart Van Assche Cc: Chris Leech Acked-by: Lee Duncan Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/libiscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -1727,7 +1727,7 @@ int iscsi_queuecommand(struct Scsi_Host if (test_bit(ISCSI_SUSPEND_BIT, &conn->suspend_tx)) { reason = FAILURE_SESSION_IN_RECOVERY; - sc->result = DID_REQUEUE; + sc->result = DID_REQUEUE << 16; goto fault; }