From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter H <peter_hong@fintek.com.tw>,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 2/5] USB: serial: f81232: add high baud rate support
Date: Tue, 30 Jan 2018 14:30:59 +1100 [thread overview]
Message-ID: <20180130033059.GA3434@localhost> (raw)
In-Reply-To: <7d8c1ff5-06fa-28f3-c5e8-3211497a6b17@gmail.com>
On Tue, Jan 23, 2018 at 10:08:24AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi Andy,
>
> Andy Shevchenko 於 2018/1/22 下午 10:55 寫道:
> > On Mon, Jan 22, 2018 at 9:58 AM, Ji-Ze Hong (Peter Hong)
> > <hpeter@gmail.com> wrote:
> >> The F81232 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates
> >> can be up to 1.5Mbits with 24MHz.
> >>
> >> F81232 Clock registers (106h)
> >>
> >> Bit1-0: Clock source selector
> >> 00: 1.846MHz.
> >> 01: 18.46MHz.
> >> 10: 24MHz.
> >> 11: 14.77MHz.
> >
> > Hmm... Why not to provide a proper clk driver (based on table variant
> > of clk-divider) and use it here?
>
> It seems too complex to use clock framework in this driver.
> What do you think about this, Johan ?
Yeah, you don't need to implement a clk driver for this. If anyone
thinks that would simplify things, I'd be happy to consider it as a
follow-on patch.
Thanks,
Johan
next prev parent reply other threads:[~2018-01-30 3:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:58 [PATCH 1/5] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 2/5] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-22 14:55 ` Andy Shevchenko
2018-01-23 2:08 ` Ji-Ze Hong (Peter Hong)
2018-01-30 3:30 ` Johan Hovold [this message]
2018-01-22 7:58 ` [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-01-30 3:57 ` Johan Hovold
2018-02-01 3:13 ` Ji-Ze Hong (Peter Hong)
2018-02-04 1:46 ` Johan Hovold
2018-02-08 9:17 ` Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 4/5] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-01-30 4:11 ` Johan Hovold
2018-02-01 5:50 ` Ji-Ze Hong (Peter Hong)
2018-02-04 1:50 ` Johan Hovold
2018-01-22 10:06 ` [PATCH 1/5] USB: serial: f81232: clear overrun flag Oliver Neukum
2018-01-23 1:50 ` Ji-Ze Hong (Peter Hong)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130033059.GA3434@localhost \
--to=johan@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).