From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-711274-1517283123-2-13634290243631012866 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517283123; b=rllic28VQVjQ/wI13PTv6+dLNX5QgbCJmVmZm/8k1iM1667 OtSSZvhIcYQHlAhx4PImf9U/M7R72HXLQgF1O85PwmLbtQaDBt090yu219SLw5hj JtQdQ76na5wWHFEtzasYOBj3fP1deZL/A8Gren1uyGXCCZbiZ7YVea3YYPK0sJp9 o2nKIUaoNYiQnZnk/9Offk0P1cYnzM7a9muWcaaKGU4tybDnDJv+vmvkcvZ0EI65 wBV+FOE4TtKiRPTs6YFDU7zP4sSGXD8I5Qp9HE9WrXmJhlFLLfoZLRg33tRkY7X/ ZbtZy2XeeEthZTzQ6Nz7xq3CXWB5qpT4SD5zMrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to:sender:list-id; s=arctest; t=1517283123; bh=lITRtsv /yjdBfzwEtNDUO2iDwbjXFv0u+bbfFoHrnr4=; b=k5DQ4N6j/HZK8GRad4yXP71 zlN/w7IRAwhrOk1J7hvV+HbsoeEmVT4FfgFB3PFx9HlUclwfuI+o+8qSMTmUcP0z +xDMXiIcNl8v3cIPnMG7BKjaWlUg5G8KVqlfM3THt0blWzIj9tj6khClvwWvat8N 1C43x++n0xkLEZG91V6Hs5bDbYT5Cy/LOGUMI45YY358ZROYoTzfO1CkY/qGBDv9 3ptJBwYrV/8nDADHystTn4rzhK1ttSKcCNNQ/3gihXdxxu8+leWbRSHp74WXsGOj C3x1GPeuP4N11LqvJeDI3VMVECi/hBbH+j3pgDcWhjnr9ttDG+ARyUvfjY1aduw= = ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=huWBGZvd x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=VPD0Beu7; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=huWBGZvd x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=VPD0Beu7; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752325AbeA3Dbt (ORCPT ); Mon, 29 Jan 2018 22:31:49 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:43614 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbeA3Dbs (ORCPT ); Mon, 29 Jan 2018 22:31:48 -0500 X-Google-Smtp-Source: AH8x224cqkztCNGdHZ6SzXxnZ7lsEBKxNYds96OGA7YngxLFBR0Ii0VEFCdiR0qLwGewdIVYvE5r/g== X-Google-Original-Sender: Date: Tue, 30 Jan 2018 14:30:59 +1100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: Andy Shevchenko , Johan Hovold , Greg Kroah-Hartman , USB , Linux Kernel Mailing List , Peter H , "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH 2/5] USB: serial: f81232: add high baud rate support Message-ID: <20180130033059.GA3434@localhost> References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> <1516607927-8887-2-git-send-email-hpeter+linux_kernel@gmail.com> <7d8c1ff5-06fa-28f3-c5e8-3211497a6b17@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7d8c1ff5-06fa-28f3-c5e8-3211497a6b17@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, Jan 23, 2018 at 10:08:24AM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Andy, > > Andy Shevchenko 於 2018/1/22 下午 10:55 寫道: > > On Mon, Jan 22, 2018 at 9:58 AM, Ji-Ze Hong (Peter Hong) > > wrote: > >> The F81232 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates > >> can be up to 1.5Mbits with 24MHz. > >> > >> F81232 Clock registers (106h) > >> > >> Bit1-0: Clock source selector > >> 00: 1.846MHz. > >> 01: 18.46MHz. > >> 10: 24MHz. > >> 11: 14.77MHz. > > > > Hmm... Why not to provide a proper clk driver (based on table variant > > of clk-divider) and use it here? > > It seems too complex to use clock framework in this driver. > What do you think about this, Johan ? Yeah, you don't need to implement a clk driver for this. If anyone thinks that would simplify things, I'd be happy to consider it as a follow-on patch. Thanks, Johan