From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-790351-1517284732-2-1938333458635914248 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517284732; b=oHnJKIJngTVVonuWwAkZM5yz/O0kfVu3a+VDPGJsQor+Whx WJCsCuD9AfN0R4jDAyyqfDA06rcUdUHfzqEhCMBdU5fw6n/pWxWH6pr7kjyprV7B llnYfhiQldPxyT+c0P9Zsjiq70GHSTCeAm3ehi4WCHw5nk06AkEFVFf0+8q/S/fJ Yo6c8Eq8tJUYJWxfTHFch2hUE7gMFDWGvAQly0Dtw2LTJeBY9dyGJ6O6yLsdpwls XJw4l2vu4z8TnaGYipXVg7QwW2UXRSqeXfHSgUUxD2cpfJ/83ScQOlmaoeNJoK2F HkfOPLPk7WXSku7aAD2Nmr58//+evedIVyK3wqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1517284732; bh=nfHxG7qYiAloF4ISU0BHKpW8Yk B+hS4O6i0go675Qf8=; b=Acgbn26/sVS3YDPFa9tVnreHE30rfOOJ9Hb341cYcK BCE237IVe/B9XkjU9loUyxh9N2a5IFrmDfKxt90LrHMSY1Q1G14p2xj+pf/inzV7 Arl4nPaeQVE+GXIOIlQjjX3T75t+k5RhAUejR0+hnGSnwI4/a7fE0V8JvEECzWCa wl4/cYjYwDef0gHCqwZpxDyIBuqWbNIS8pC/y964g61QV+waa2batQrSidqOFgkx cF8UOs1gG5OnndLDmWi2RzhQEkMa/lDjbdG4L1f2It3jRqOvkzaFZfYs1kaoMoXr M0d0L8uwAu2ts74gU1qbve0bhYjRNuCfXKRGhOK1eVMg== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=UnwLecdE x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=MmJkVstX; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=UnwLecdE x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=MmJkVstX; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752300AbeA3D6h (ORCPT ); Mon, 29 Jan 2018 22:58:37 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:40206 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbeA3D6g (ORCPT ); Mon, 29 Jan 2018 22:58:36 -0500 X-Google-Smtp-Source: AH8x226bdAy5OHWVFpdUKLwk11Iij3rKb5XshSxJ2iEqhFwvGMHykfMZ0NeSTJwbw/bAII3oppZO2g== X-Google-Original-Sender: Date: Tue, 30 Jan 2018 14:57:47 +1100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Message-ID: <20180130035747.GB3434@localhost> References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> <1516607927-8887-3-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516607927-8887-3-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 22, 2018 at 03:58:45PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81232 can do remote wakeup via RX/RI pin with pulse. > This patch will use device_set_wakeup_enable to enable this > feature. This is a policy decision that should be made by user space by setting the power/wakeup attribute, and not something that something that drivers should enable directly themselves. Perhaps you really wanted to use device_set_wakeup_capable()? But then you also need to honour the current setting in suspend() as well. How have you tested this feature? Johan