From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-790351-1517285579-2-9222318812783205395 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517285575; b=kwNP3E+oJDN0M/8E9t5iODdgiu0NnAWUNKTY5crrbBFcMOa ZO0BLUN7v2Q8nEwPCSIvIZ6fcQfv6yHMh6X5bkqV8E016wfwzWcQPcXbBr2hoeBv O0Vg1HRcTRZygZF9cZ68EpDLkd4CEumakPlElAEKGgfhcP7scMAP/FuSOfRcuMAl mvLlns8B0qYP7jHH2cXGqbbg+mDM9syYVuEUtdxssLXRElj6w3XsqrDxH5zjma9W BD3eUc+LxE2CUWvsGtiAp8DaBWGQzEBHf1SorMCqeul2ChM478G41Bte7Q+ztjSA 5LMoeVzHHAjkjkUdOtRc/kvYDmYDJwQzbEi3JYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1517285575; bh=ImiZDfvaWDWfkdZqQMqyAoLeB3 pkzT0JYsTx9s6p+ZI=; b=rx0gdo1bYUJRXyNHfsjSOJpIzjMU/4JaUFpCu+f+D6 g4TmfIcTNVjNKqjIfkYjv9TQognHmN6pfe2F/5BnxIUlTmWV7/3keGq8rtKQd2WX jsfoFRwG64VRlOc8NheeqYU6c2DdedQ5SFELW5A4wEd6Y3gnDOL3dZB0OI500kga EvEEwCrIUZHjaWMAXKAwGlvLA/uTDMzUtCDMybK5605uWny7y7qgJUJL5ciscUwb 0TsEPnrY798sm+N/J0qsFXi2/EgZfpTalIDdiSKc0SRv/DlEtvTFkvkwtKahzKW1 TTDUUTV/6o/lbREDTGhWRDluVkELm52Qr2BnVHqneYtA== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=DV+3MHal x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=R2kpsnnX; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=DV+3MHal x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=R2kpsnnX; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbeA3EMj (ORCPT ); Mon, 29 Jan 2018 23:12:39 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:40375 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbeA3EMi (ORCPT ); Mon, 29 Jan 2018 23:12:38 -0500 X-Google-Smtp-Source: AH8x2276dyMlp0kyf1J2scy7yxAwuvx79D6Omr3hKFkL2MDi/HMtogjQ96V/5/RMQGGk3/9AyLn/Kg== X-Google-Original-Sender: Date: Tue, 30 Jan 2018 15:11:50 +1100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size Message-ID: <20180130041150.GC3434@localhost> References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> <1516607927-8887-5-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516607927-8887-5-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 22, 2018 at 03:58:47PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec. > http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > drivers/usb/serial/f81232.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c > index a054f69446fd..f3ee537d643c 100644 > --- a/drivers/usb/serial/f81232.c > +++ b/drivers/usb/serial/f81232.c > @@ -769,8 +769,7 @@ static struct usb_serial_driver f81232_device = { > }, > .id_table = id_table, > .num_ports = 1, > - .bulk_in_size = 256, > - .bulk_out_size = 256, > + .bulk_out_size = 16, These fields control the URB buffer sizes and defaults to the corresponding endpoint max-packet size, which would be 16 for all endpoints according to the datasheet above. So it seems you should really be setting bulk_in_size to 64 here (and possibly leave bulk_out_size unset) as that would appear to match your device buffer sizes. Johan