public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw2@infradead.org>,
	karahmed@amazon.de, x86@kernel.org, linux-kernel@vger.kernel.org,
	tim.c.chen@linux.intel.com, peterz@infradead.org,
	pbonzini@redhat.com, ak@linux.intel.com,
	torvalds@linux-foundation.org, gregkh@linux-foundation.org
Subject: Re: [PATCH] x86/cpuid: Fix up "virtual" IBRS/IBPB/STIBP feature bits on Intel
Date: Tue, 30 Jan 2018 14:54:17 +0000	[thread overview]
Message-ID: <20180130145417.71b0c859@alans-desktop> (raw)
In-Reply-To: <37c4e2a7-6e35-d736-dfaf-83fbe4895401@linux.intel.com>

On Tue, 30 Jan 2018 06:01:43 -0800
Arjan van de Ven <arjan@linux.intel.com> wrote:

> On 1/30/2018 5:11 AM, Borislav Petkov wrote:
> > On Tue, Jan 30, 2018 at 01:57:21PM +0100, Thomas Gleixner wrote:  
> >> So much for the theory. That's not going to work. If the boot cpu has the
> >> feature then the alternatives will have been applied. So even if the flag
> >> mismatch can be observed when a secondary CPU comes up the outcome will be
> >> access to a non existing MSR and #GP.  
> > 
> > Yes, with mismatched microcode we're f*cked.  
> 
> I think in the super early days of SMP there was an occasional broken BIOS.
> (and when Linux then did the ucode update it was sane again)
> 
> Not since a long time though (I think the various certification suites check for it now)

The only case I can think of where you'd get a non boot processor that
didn't have the same microcode loaded as the rest on entry to the OS would
be in a system where it was possibly to phyically hot plug processors
post boot.

There are not many such systems and it may be that all of them do
sufficient deeply unmentionable things in their firmware to cover this.

Alan

  reply	other threads:[~2018-01-30 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 23:49 [PATCH] x86/cpuid: Fix up "virtual" IBRS/IBPB/STIBP feature bits on Intel David Woodhouse
2018-01-30 10:37 ` Thomas Gleixner
2018-01-30 10:58 ` Borislav Petkov
2018-01-30 11:03   ` David Woodhouse
2018-01-30 11:18     ` Borislav Petkov
2018-01-30 11:28       ` David Woodhouse
2018-01-30 11:37         ` Thomas Gleixner
2018-01-30 12:09           ` David Woodhouse
2018-01-30 12:57             ` Thomas Gleixner
2018-01-30 13:11               ` Borislav Petkov
2018-01-30 14:01                 ` Arjan van de Ven
2018-01-30 14:54                   ` Alan Cox [this message]
2018-01-30 14:57                     ` David Woodhouse
2018-01-30 18:19                 ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130145417.71b0c859@alans-desktop \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=ak@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linux-foundation.org \
    --cc=karahmed@amazon.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox