* [PATCH v2] drm/edid: use true and false for boolean values @ 2018-01-30 10:05 Gustavo A. R. Silva 2018-01-30 15:09 ` Sean Paul 0 siblings, 1 reply; 6+ messages in thread From: Gustavo A. R. Silva @ 2018-01-30 10:05 UTC (permalink / raw) To: Daniel Vetter, Gustavo Padovan, Sean Paul, David Airlie Cc: dri-devel, linux-kernel, Gustavo A. R. Silva Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- Changes in v2: - Use true for boolean value in add_detailed_mode as suggested by Daniel Vetter. - Update subject. drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ddd5379..b1cb262 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) drm_mode_probed_add(closure->connector, newmode); closure->modes++; - closure->preferred = 0; + closure->preferred = false; } } @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, struct detailed_mode_closure closure = { .connector = connector, .edid = edid, - .preferred = 1, + .preferred = true, .quirks = quirks, }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/edid: use true and false for boolean values 2018-01-30 10:05 [PATCH v2] drm/edid: use true and false for boolean values Gustavo A. R. Silva @ 2018-01-30 15:09 ` Sean Paul 2018-01-30 15:19 ` Ville Syrjälä 0 siblings, 1 reply; 6+ messages in thread From: Sean Paul @ 2018-01-30 15:09 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: Daniel Vetter, Gustavo Padovan, Sean Paul, David Airlie, dri-devel, linux-kernel, Gustavo A. R. Silva On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. I suppose you could also fix up the other preferred assignment by adding !! to the bitwise & operation. It's also helpful to post the spatch in the commit message so others can replicate your result (this case is pretty trivial, so less important). Sean > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > Changes in v2: > - Use true for boolean value in add_detailed_mode as suggested by Daniel > Vetter. > - Update subject. > > drivers/gpu/drm/drm_edid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index ddd5379..b1cb262 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > drm_mode_probed_add(closure->connector, newmode); > closure->modes++; > - closure->preferred = 0; > + closure->preferred = false; > } > } > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > struct detailed_mode_closure closure = { > .connector = connector, > .edid = edid, > - .preferred = 1, > + .preferred = true, > .quirks = quirks, > }; > > -- > 2.7.4 > -- Sean Paul, Software Engineer, Google / Chromium OS ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/edid: use true and false for boolean values 2018-01-30 15:09 ` Sean Paul @ 2018-01-30 15:19 ` Ville Syrjälä 2018-01-30 15:31 ` Jani Nikula 2018-01-30 16:02 ` Sean Paul 0 siblings, 2 replies; 6+ messages in thread From: Ville Syrjälä @ 2018-01-30 15:19 UTC (permalink / raw) To: Sean Paul Cc: Gustavo A. R. Silva, David Airlie, linux-kernel, dri-devel, Daniel Vetter, Gustavo A. R. Silva On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > Assign true or false to boolean variables instead of an integer value. > > > > This issue was detected with the help of Coccinelle. > > I suppose you could also fix up the other preferred assignment by adding !! > to the bitwise & operation. Assigning >1 to a bool is well defined. No need to clutter the code with !! imo. > > It's also helpful to post the spatch in the commit message so others can > replicate your result (this case is pretty trivial, so less important). > > Sean > > > > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > --- > > Changes in v2: > > - Use true for boolean value in add_detailed_mode as suggested by Daniel > > Vetter. > > - Update subject. > > > > drivers/gpu/drm/drm_edid.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > index ddd5379..b1cb262 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > > > drm_mode_probed_add(closure->connector, newmode); > > closure->modes++; > > - closure->preferred = 0; > > + closure->preferred = false; > > } > > } > > > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > > struct detailed_mode_closure closure = { > > .connector = connector, > > .edid = edid, > > - .preferred = 1, > > + .preferred = true, > > .quirks = quirks, > > }; > > > > -- > > 2.7.4 > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/edid: use true and false for boolean values 2018-01-30 15:19 ` Ville Syrjälä @ 2018-01-30 15:31 ` Jani Nikula 2018-01-30 16:02 ` Sean Paul 1 sibling, 0 replies; 6+ messages in thread From: Jani Nikula @ 2018-01-30 15:31 UTC (permalink / raw) To: Ville Syrjälä, Sean Paul Cc: Gustavo A. R. Silva, David Airlie, linux-kernel, dri-devel, Gustavo A. R. Silva, Daniel Vetter On Tue, 30 Jan 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: >> On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: >> > Assign true or false to boolean variables instead of an integer value. >> > >> > This issue was detected with the help of Coccinelle. >> >> I suppose you could also fix up the other preferred assignment by adding !! >> to the bitwise & operation. > > Assigning >1 to a bool is well defined. No need to clutter the code with > !! imo. Agreed. BR, Jani. > >> >> It's also helpful to post the spatch in the commit message so others can >> replicate your result (this case is pretty trivial, so less important). >> >> Sean >> >> > >> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> > --- >> > Changes in v2: >> > - Use true for boolean value in add_detailed_mode as suggested by Daniel >> > Vetter. >> > - Update subject. >> > >> > drivers/gpu/drm/drm_edid.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> > index ddd5379..b1cb262 100644 >> > --- a/drivers/gpu/drm/drm_edid.c >> > +++ b/drivers/gpu/drm/drm_edid.c >> > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) >> > >> > drm_mode_probed_add(closure->connector, newmode); >> > closure->modes++; >> > - closure->preferred = 0; >> > + closure->preferred = false; >> > } >> > } >> > >> > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, >> > struct detailed_mode_closure closure = { >> > .connector = connector, >> > .edid = edid, >> > - .preferred = 1, >> > + .preferred = true, >> > .quirks = quirks, >> > }; >> > >> > -- >> > 2.7.4 >> > >> >> -- >> Sean Paul, Software Engineer, Google / Chromium OS >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/edid: use true and false for boolean values 2018-01-30 15:19 ` Ville Syrjälä 2018-01-30 15:31 ` Jani Nikula @ 2018-01-30 16:02 ` Sean Paul 2018-01-30 16:31 ` Daniel Vetter 1 sibling, 1 reply; 6+ messages in thread From: Sean Paul @ 2018-01-30 16:02 UTC (permalink / raw) To: Ville Syrjälä Cc: Sean Paul, Gustavo A. R. Silva, David Airlie, linux-kernel, dri-devel, Daniel Vetter, Gustavo A. R. Silva On Tue, Jan 30, 2018 at 05:19:46PM +0200, Ville Syrjälä wrote: > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > > Assign true or false to boolean variables instead of an integer value. > > > > > > This issue was detected with the help of Coccinelle. > > > > I suppose you could also fix up the other preferred assignment by adding !! > > to the bitwise & operation. > > Assigning >1 to a bool is well defined. No need to clutter the code with > !! imo. There are examples of both in the file already. I don't have strong feelings either way. Sea > > > > > It's also helpful to post the spatch in the commit message so others can > > replicate your result (this case is pretty trivial, so less important). > > > > Sean > > > > > > > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > > --- > > > Changes in v2: > > > - Use true for boolean value in add_detailed_mode as suggested by Daniel > > > Vetter. > > > - Update subject. > > > > > > drivers/gpu/drm/drm_edid.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > index ddd5379..b1cb262 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > > > > > drm_mode_probed_add(closure->connector, newmode); > > > closure->modes++; > > > - closure->preferred = 0; > > > + closure->preferred = false; > > > } > > > } > > > > > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > > > struct detailed_mode_closure closure = { > > > .connector = connector, > > > .edid = edid, > > > - .preferred = 1, > > > + .preferred = true, > > > .quirks = quirks, > > > }; > > > > > > -- > > > 2.7.4 > > > > > > > -- > > Sean Paul, Software Engineer, Google / Chromium OS > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Ville Syrjälä > Intel OTC -- Sean Paul, Software Engineer, Google / Chromium OS ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/edid: use true and false for boolean values 2018-01-30 16:02 ` Sean Paul @ 2018-01-30 16:31 ` Daniel Vetter 0 siblings, 0 replies; 6+ messages in thread From: Daniel Vetter @ 2018-01-30 16:31 UTC (permalink / raw) To: Sean Paul Cc: Ville Syrjälä, Gustavo A. R. Silva, David Airlie, Gustavo A. R. Silva, linux-kernel, dri-devel, Daniel Vetter On Tue, Jan 30, 2018 at 11:02:44AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 05:19:46PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > > > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > > > Assign true or false to boolean variables instead of an integer value. > > > > > > > > This issue was detected with the help of Coccinelle. > > > > > > I suppose you could also fix up the other preferred assignment by adding !! > > > to the bitwise & operation. > > > > Assigning >1 to a bool is well defined. No need to clutter the code with > > !! imo. > > There are examples of both in the file already. I don't have strong feelings > either way. Yeah, I applied this one for now, we can do more color choice discussions with follow ups :-) Thanks for the patch. -Daniel > > Sea > > > > > > > > > It's also helpful to post the spatch in the commit message so others can > > > replicate your result (this case is pretty trivial, so less important). > > > > > > Sean > > > > > > > > > > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > > > --- > > > > Changes in v2: > > > > - Use true for boolean value in add_detailed_mode as suggested by Daniel > > > > Vetter. > > > > - Update subject. > > > > > > > > drivers/gpu/drm/drm_edid.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > > index ddd5379..b1cb262 100644 > > > > --- a/drivers/gpu/drm/drm_edid.c > > > > +++ b/drivers/gpu/drm/drm_edid.c > > > > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > > > > > > > drm_mode_probed_add(closure->connector, newmode); > > > > closure->modes++; > > > > - closure->preferred = 0; > > > > + closure->preferred = false; > > > > } > > > > } > > > > > > > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > > > > struct detailed_mode_closure closure = { > > > > .connector = connector, > > > > .edid = edid, > > > > - .preferred = 1, > > > > + .preferred = true, > > > > .quirks = quirks, > > > > }; > > > > > > > > -- > > > > 2.7.4 > > > > > > > > > > -- > > > Sean Paul, Software Engineer, Google / Chromium OS > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Ville Syrjälä > > Intel OTC > > -- > Sean Paul, Software Engineer, Google / Chromium OS > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-30 16:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-01-30 10:05 [PATCH v2] drm/edid: use true and false for boolean values Gustavo A. R. Silva 2018-01-30 15:09 ` Sean Paul 2018-01-30 15:19 ` Ville Syrjälä 2018-01-30 15:31 ` Jani Nikula 2018-01-30 16:02 ` Sean Paul 2018-01-30 16:31 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox