* [PATCH] Staging: speakup: Fixed a multiple assignment issue
@ 2018-01-31 6:19 Shannon Booth
2018-01-31 8:41 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Booth @ 2018-01-31 6:19 UTC (permalink / raw)
To: gregkh; +Cc: devel, speakup, linux-kernel, Shannon Booth
Fixed a coding style issue.
Signed-off-by: Shannon Booth <shannon.ml.booth@gmail.com>
---
drivers/staging/speakup/main.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index cf12590..b721f41 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -261,9 +261,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
static void speakup_date(struct vc_data *vc)
{
- spk_x = spk_cx = vc->vc_x;
- spk_y = spk_cy = vc->vc_y;
- spk_pos = spk_cp = vc->vc_pos;
+ spk_x = vc->vc_x;
+ spk_cx = vc->vc_x;
+ spk_y = vc->vc_y;
+ spk_cy = vc->vc_y;
+ spk_pos = vc->vc_pos;
+ spk_cp = vc->vc_pos;
spk_old_attr = spk_attr;
spk_attr = get_attributes(vc, (u_short *)spk_pos);
}
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: speakup: Fixed a multiple assignment issue
2018-01-31 6:19 [PATCH] Staging: speakup: Fixed a multiple assignment issue Shannon Booth
@ 2018-01-31 8:41 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-01-31 8:41 UTC (permalink / raw)
To: Shannon Booth; +Cc: devel, speakup, linux-kernel
On Wed, Jan 31, 2018 at 07:19:05PM +1300, Shannon Booth wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Shannon Booth <shannon.ml.booth@gmail.com>
> ---
> drivers/staging/speakup/main.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index cf12590..b721f41 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -261,9 +261,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
>
> static void speakup_date(struct vc_data *vc)
> {
> - spk_x = spk_cx = vc->vc_x;
> - spk_y = spk_cy = vc->vc_y;
> - spk_pos = spk_cp = vc->vc_pos;
> + spk_x = vc->vc_x;
> + spk_cx = vc->vc_x;
> + spk_y = vc->vc_y;
> + spk_cy = vc->vc_y;
> + spk_pos = vc->vc_pos;
> + spk_cp = vc->vc_pos;
The original code looks much better than this, don't you agree?
Coding style is just a guideline, no need to change things that don't
make sense.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-31 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-31 6:19 [PATCH] Staging: speakup: Fixed a multiple assignment issue Shannon Booth
2018-01-31 8:41 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox