From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-212041-1517388074-2-10168516766035219802 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES ensv, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517388074; b=qQxX9GMFRT2gtNVHJXS//tWFTBp3v2GDh3gtMogOujv37U+ DzxARFD9Qi/pYb5VL0NnTMQi0t65WCpFUtVIhwB7B9A1CBa4ATbNNYda7TYOxC5q EvgRIC+WScL9Bc84Ec+XhkHrQjH1lEzMcIhMCDHt4Xgy9+iNZdBRDu5OMqZA5iRX G9dSMYJPqh0NUCQFZwSBfVJ2+Wx2DCM/ITeIuL6Z4p3eaSfq95RMzY2ypeC5F/r2 Wzs59Xl3CN6gsjBYykXdOzWrKhmXLWFobb8ZvpkthO++p8DyxvTdTRyABgy1t9/t CaiTL0tOoyGfQk91rKvHlXZGUKN/8duaPY7c0mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1517388074; bh=p XP2tADs8Ih/rnF6aeL79kFKmhYW+1PBUvMNLfoj6CA=; b=ZvfbmYvNyTSzHN+kl lquJ8IcgX1re4VSDVHplmpMH3zXjHrIC+9fjV66PReIsOhKanyXP9dHxupPu7lxk 00S/QVHULwC3K8F3K2j8CUOJUOyDeSKrJ+e3bBp1Ernxcyujk2VKcqvy/z4rkGzR z7gmWR41SfY5hao85WHP3M0y5YDgjR5eBY8oS5S3PTdgnnty/H/u6rkQwUs7EI1r QfANxYqcqTJdxIKencbTdB/akWJbsbgzqe7vT5cJxYAToFi0HNK2TjlagVjlW3rK 0/5XjJkVkS6ftKyOXPxNL1TMGk9sZOTh879o2a/owzzBBFEO/Dbplyx3ZyoEA6tS qQ6QQ== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Wed, 31 Jan 2018 09:41:04 +0100 From: Greg KH To: Shannon Booth Subject: Re: [PATCH] Staging: speakup: Fixed a multiple assignment issue Message-ID: <20180131084104.GC32583@kroah.com> References: <1517379545-31318-1-git-send-email-shannon.ml.booth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1517379545-31318-1-git-send-email-shannon.ml.booth@gmail.com> User-Agent: Mutt/1.9.3 (2018-01-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 31, 2018 at 07:19:05PM +1300, Shannon Booth wrote: > Fixed a coding style issue. > > Signed-off-by: Shannon Booth > --- > drivers/staging/speakup/main.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index cf12590..b721f41 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -261,9 +261,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos) > > static void speakup_date(struct vc_data *vc) > { > - spk_x = spk_cx = vc->vc_x; > - spk_y = spk_cy = vc->vc_y; > - spk_pos = spk_cp = vc->vc_pos; > + spk_x = vc->vc_x; > + spk_cx = vc->vc_x; > + spk_y = vc->vc_y; > + spk_cy = vc->vc_y; > + spk_pos = vc->vc_pos; > + spk_cp = vc->vc_pos; The original code looks much better than this, don't you agree? Coding style is just a guideline, no need to change things that don't make sense. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel