From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.busch@intel.com>
X-Google-Smtp-Source: AH8x2240PORtdvwATzZHuKt6+xxPGityn+dn8F5sWybrWqGc84Hc/xjXn1wPaTnBEs3C5YDeB8YF
ARC-Seal: i=1; a=rsa-sha256; t=1517415883; cv=none;
        d=google.com; s=arc-20160816;
        b=d0IFO4RItHvPjxpjnws87rCkxhoVRqiGXwKv8FTWmNjAGvHAc/+fL1shekK0S1Knjj
         jTJdQ3N2Pbawf3FDmgrxVEMN3zMxa/GxhFIqf4S5/646fEqP2xUlnXh2pj/0ZK/emht2
         oIACC8ecf9fw6J2HhsCLEC+5K0UzSl1CuvnGCDuJetzJe6/JeJJBJ9a7PPZA23jR3S1F
         qXGzefJMomZFqRuTdpX0niOi+IXHvke1+pn4GqnZdsrzZuu0OtzzYQQs9NEHXnxhdjVR
         B0bKirXxtWCpm3qO7BEf0WQQ4nyhvbaSww9JWu27wofIb7fxY1HTYfAROJC3/72FhmsB
         QCwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=T/lHVkmX60KQ5lGr7s9z0+FRmqMc9N/Y3XFaE74+p6s=;
        b=i5KjKkJW5JrmeM3Yq5685llNhVBq4G3xI/t7pfm3aIZ9lTxDHAO9/P1vYJacN62aAl
         HZ/0KwIr2bAhRZHGpacsqotacwtOPYOuTubehY/ckus/HaFfcStaoJbBolfaHzVHpV+e
         O+rf+TefIxnp2vRjwtrTqjc0665WH4gbsAdkDSiy2lDp6w/xm0UP4vy+Sshp3KVo29Qj
         t8El2r1fSDV26FW4bIsHDig4sTb7JS4HVE9GxGmWS4HxGd3U6SVrSRyoid3CUXqeArOJ
         TuDPImyzLwFlWqh0+6f2+jfFFtBZ0t3NTAJpYKlzFbpw71W+awEjpoRdTgYDFIVDzOIR
         7L2w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of keith.busch@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=keith.busch@intel.com
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of keith.busch@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=keith.busch@intel.com
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,440,1511856000";
   d="scan'208";a="15902178"
Date: Wed, 31 Jan 2018 09:28:26 -0700
From: Keith Busch <keith.busch@intel.com>
To: Oza Pawandeep <poza@codeaurora.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dongdong Liu <liudongdong3@huawei.com>, Wei Zhang <wzhang@fb.com>,
	Sinan Kaya <okaya@codeaurora.org>,
	Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH] PCI/DPC: Fix INT legacy interrupt in dpc_irq
Message-ID: <20180131162826.GD27735@localhost.localdomain>
References: <1517415535-21850-1-git-send-email-poza@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517415535-21850-1-git-send-email-poza@codeaurora.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1591125527357545721?=
X-GMAIL-MSGID: =?utf-8?q?1591125877468971963?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Wed, Jan 31, 2018 at 09:48:55PM +0530, Oza Pawandeep wrote:
> Current dpc driver acknowledge the interrupt in deferred work, which works
> okay since LPI are edge triggered.
> But when RP does not have MSI support, port service driver falls back to
> legacy GIC SPI interrupts, and with current code we do not acknowledge the
> interrupt and we get dpc interrupt storm.
> This patch acknowledges the interrupt in interrupt handler.
> 
> Signed-off-by: Oza Pawandeep <poza@codeaurora.org>

Thanks, looks good to me.

Reviewed-by: Keith Busch <keith.busch@intel.com>