From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227GUKuAFKQt8Lpvv9B/aMPXQ6GBJIv/mQ9jX2l8Mjfg9Rb1JTRorQ8TTNABakFCo2eBlAUs ARC-Seal: i=1; a=rsa-sha256; t=1517424043; cv=none; d=google.com; s=arc-20160816; b=ZZx3XWlYg5etAxoravmmctIcGfKieLDf7/w78JNwshULMzRsB+kXaZj/o4b4cXUC5N bh9VA0mZGExWqvdVYg4+MJ5CEQyIi/fMJpnqxl4JIOnU65nmOeZUtZIa6tSjrwuX540I AvIQtxsPaqkFkeZBLfyegcOX2R5fVFhE+wdNdfvO4YbRkL7amlra5lySayzbrBP+2LSz d/Q98pEZf14vxbbPwban1d1uiIe0LxqRc4j2/KiomDeI0PNAgZrx64HjAiX79VLdkrXm PuQxBALgrE16djecI+IdfrWuiTcQhUktZVa9THVLP5vvv/GsrbRVhv8PZCQ/sRuKbBb+ UkxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=n0DYqWvKXnB1CrpIFDLnSXuxpTMZfxFxu+0gIcVX6Ck=; b=xyHHpWitpYcOso4mvU5T/W2DY2I/GufA+K7U3YWAQHzRGjrRD9BYmVrCBSeNGOCFgm RhyJioVyP4qsCALpt2JhuqMrHUCzCDzS8BRdYJ+qhAHUu5yADcsrxPJ2XZzbxQ1/ljUe +XpGrwjYphq2xyETFKWm4Gk+AsAI+EY3FBDlp9c8R2fIBFBAbMTTBlCZNi28LDMNunOZ ea0+kxDUYF0M7jhg30qg3WxvrUEkcGrSWsqIiyiNKCXAiNMw52c83SMswtAxip5RDHxX /UCcQuurwnhtx29Y+RiFhAMz0bfOEWmHvef/o7dXec31Z2KWxM1roZovQNmZqCBeTdMO 4CHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=B4oBaTut; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=B4oBaTut; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Wed, 31 Jan 2018 10:40:38 -0800 From: Darren Hart To: Vadim Pasternak Cc: "andy.shevchenko@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create Message-ID: <20180131184038.GB8676@fury> References: <1516826019-124903-1-git-send-email-vadimp@mellanox.com> <20180125214643.GB24122@fury> <20180126234117.GB3736@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180126234117.GB3736@fury> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500036473711477?= X-GMAIL-MSGID: =?utf-8?q?1591134433134447279?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 26, 2018 at 03:41:17PM -0800, Darren Hart wrote: > On Fri, Jan 26, 2018 at 04:59:32PM +0000, Vadim Pasternak wrote: > > > > > > > -----Original Message----- > > > From: Darren Hart [mailto:dvhart@infradead.org] > > > Sent: Thursday, January 25, 2018 11:47 PM > > > To: Vadim Pasternak > > > Cc: andy.shevchenko@gmail.com; gregkh@linuxfoundation.org; linux- > > > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnulli.us > > > Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove > > > redundant dev_err messages on device_create > > > > > > On Wed, Jan 24, 2018 at 08:33:37PM +0000, Vadim Pasternak wrote: > > > > The upper layer will manage and report errors returned by the create > > > > and destroy functions. > > > > > > > > FIXME: but it doesn't - we don't even check > > > > > > I think we agreed to just drop this patch entirely, since this error is not checked > > > elsewhere? Keeping the dev_err messages? > > > > > > > Yes, we'll keep it. > > We just had conflict in patch order and I wanted to fix it, staying as much as > > possible aligned with the top of mellanox v10 branch. > > > > However currently we still have a problem in mellanox v11 after patch > > platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface > > It dropped parameter device in mlxreg_hotplug_device_create, which is > > Used inside the routine. > > > > I'll send a separate patch to fix it from top of v11. In other case it'll be > > necessary to fix Modify to use a regmap interface and re-send all from > > 5-th patch in series. > > > > Also we should drop the patch: > > platform/x86: mlx-platform: Simplify IO access to regmap context > > It introduced the issue reported by sparse. > > > > I am resending two last patches from review-dvhart-mellanox-v11 branch > > and also patch with fix for mlxreg_hotplug_device_create, as: > > 0010-platform-x86-mlx-platform-Extend-register-map-config.patch > > 0011-platform-mellanox-mlxreg-hotplug-Add-check-for-negat.patch > > 0012-platform-mellanox-mlxreg-hotplug-Fix-issue-of-commit.patch > > > > Thank you very much for your help, > > OK, please see review-dvhart-mellanox-v12 on infradead or github. I've verified > this passes a clean C=1 (sparse) build at each patch. I believe this is in a > state that can be moved to testing. Please confirm. > > If you still want to move the dev_err messages out of the create function, we > can do that separately. Let's get this merged so we can move forward. I'm pushing v12 into testing, shortly to for-next, and then on to Linus. Please speak up if there are any objections. -- Darren Hart VMware Open Source Technology Center