* [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
@ 2018-01-17 18:56 Corentin Labbe
2018-01-17 19:55 ` James Hogan
2018-02-01 12:00 ` James Hogan
0 siblings, 2 replies; 4+ messages in thread
From: Corentin Labbe @ 2018-01-17 18:56 UTC (permalink / raw)
To: ralf; +Cc: linux-kernel, linux-mips, Corentin Labbe
MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
not exists.
Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
Note that BMIP_GENERIC do the same which confirm that this patch is
needed.
Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
arch/mips/Kconfig | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 13c6e5cb6055..504e78ff0b00 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -119,12 +119,12 @@ config MIPS_GENERIC
select SYS_SUPPORTS_MULTITHREADING
select SYS_SUPPORTS_RELOCATABLE
select SYS_SUPPORTS_SMARTMIPS
- select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
- select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
- select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
- select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
- select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
- select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
+ select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+ select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
+ select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+ select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
+ select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+ select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
select USE_OF
help
Select this to build a kernel which aims to support multiple boards,
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
2018-01-17 18:56 [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN Corentin Labbe
@ 2018-01-17 19:55 ` James Hogan
2018-01-31 22:42 ` James Hogan
2018-02-01 12:00 ` James Hogan
1 sibling, 1 reply; 4+ messages in thread
From: James Hogan @ 2018-01-17 19:55 UTC (permalink / raw)
To: Corentin Labbe; +Cc: ralf, linux-kernel, linux-mips
[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]
On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> not exists.
> Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> Note that BMIP_GENERIC do the same which confirm that this patch is
> needed.
>
> Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Good spot:
Reviewed-by: James Hogan <jhogan@kernel.org>
Probably worthy of a backport too:
Cc: <stable@vger.kernel.org> # 4.9+
Cheers
James
> ---
> arch/mips/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 13c6e5cb6055..504e78ff0b00 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -119,12 +119,12 @@ config MIPS_GENERIC
> select SYS_SUPPORTS_MULTITHREADING
> select SYS_SUPPORTS_RELOCATABLE
> select SYS_SUPPORTS_SMARTMIPS
> - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> select USE_OF
> help
> Select this to build a kernel which aims to support multiple boards,
> --
> 2.13.6
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
2018-01-17 19:55 ` James Hogan
@ 2018-01-31 22:42 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2018-01-31 22:42 UTC (permalink / raw)
To: Corentin Labbe; +Cc: ralf, linux-kernel, linux-mips
[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]
On Wed, Jan 17, 2018 at 07:55:27PM +0000, James Hogan wrote:
> On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> > MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> > not exists.
> > Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> > Note that BMIP_GENERIC do the same which confirm that this patch is
> > needed.
> >
> > Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Good spot:
> Reviewed-by: James Hogan <jhogan@kernel.org>
>
> Probably worthy of a backport too:
> Cc: <stable@vger.kernel.org> # 4.9+
For the record, this needs the patch "usb: Move USB_UHCI_BIG_ENDIAN_*
out of USB_SUPPORT" [1] to avoid Kconfig warnings.
Thanks
James
[1] https://patchwork.linux-mips.org/patch/18559/
>
> Cheers
> James
>
> > ---
> > arch/mips/Kconfig | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 13c6e5cb6055..504e78ff0b00 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -119,12 +119,12 @@ config MIPS_GENERIC
> > select SYS_SUPPORTS_MULTITHREADING
> > select SYS_SUPPORTS_RELOCATABLE
> > select SYS_SUPPORTS_SMARTMIPS
> > - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > select USE_OF
> > help
> > Select this to build a kernel which aims to support multiple boards,
> > --
> > 2.13.6
> >
> >
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
2018-01-17 18:56 [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN Corentin Labbe
2018-01-17 19:55 ` James Hogan
@ 2018-02-01 12:00 ` James Hogan
1 sibling, 0 replies; 4+ messages in thread
From: James Hogan @ 2018-02-01 12:00 UTC (permalink / raw)
To: Corentin Labbe; +Cc: ralf, linux-kernel, linux-mips
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> not exists.
> Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> Note that BMIP_GENERIC do the same which confirm that this patch is
> needed.
>
> Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
I've already applied this to my 4.16 branch, with minor commit message
tweaks.
Thanks
James
> ---
> arch/mips/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 13c6e5cb6055..504e78ff0b00 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -119,12 +119,12 @@ config MIPS_GENERIC
> select SYS_SUPPORTS_MULTITHREADING
> select SYS_SUPPORTS_RELOCATABLE
> select SYS_SUPPORTS_SMARTMIPS
> - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> select USE_OF
> help
> Select this to build a kernel which aims to support multiple boards,
> --
> 2.13.6
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-01 12:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 18:56 [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN Corentin Labbe
2018-01-17 19:55 ` James Hogan
2018-01-31 22:42 ` James Hogan
2018-02-01 12:00 ` James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox