From: James Hogan <jhogan@kernel.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: ralf@linux-mips.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
Date: Thu, 1 Feb 2018 12:00:29 +0000 [thread overview]
Message-ID: <20180201120028.GG7637@saruman> (raw)
In-Reply-To: <20180117185638.22426-1-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> not exists.
> Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> Note that BMIP_GENERIC do the same which confirm that this patch is
> needed.
>
> Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
I've already applied this to my 4.16 branch, with minor commit message
tweaks.
Thanks
James
> ---
> arch/mips/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 13c6e5cb6055..504e78ff0b00 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -119,12 +119,12 @@ config MIPS_GENERIC
> select SYS_SUPPORTS_MULTITHREADING
> select SYS_SUPPORTS_RELOCATABLE
> select SYS_SUPPORTS_SMARTMIPS
> - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> select USE_OF
> help
> Select this to build a kernel which aims to support multiple boards,
> --
> 2.13.6
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-02-01 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:56 [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN Corentin Labbe
2018-01-17 19:55 ` James Hogan
2018-01-31 22:42 ` James Hogan
2018-02-01 12:00 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201120028.GG7637@saruman \
--to=jhogan@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox