From: Juri Lelli <juri.lelli@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: peterz@infradead.org, lizefan@huawei.com, mingo@redhat.com,
rostedt@goodmis.org, claudio@evidence.eu.com, bristot@redhat.com,
tommaso.cucinotta@santannapisa.it, luca.abeni@santannapisa.it,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/7] sched/topology: Adding function partition_sched_domains_locked()
Date: Fri, 2 Feb 2018 11:19:51 +0100 [thread overview]
Message-ID: <20180202101951.GS19535@localhost.localdomain> (raw)
In-Reply-To: <1517503869-3179-2-git-send-email-mathieu.poirier@linaro.org>
Hi Mathieu,
On 01/02/18 09:51, Mathieu Poirier wrote:
> Introducing function partition_sched_domains_locked() by taking
> the mutex locking code out of the original function. That way
> the work done by partition_sched_domains_locked() can be reused
> without dropping the mutex lock.
>
> This patch doesn't change the functionality provided by the
> original code.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
[...]
> +/*
> + * Call with hotplug lock held
Is this the one that we can actually check if it's locked with
lockdep_assert_cpus_held()
?
> + */
> +void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
> + struct sched_domain_attr *dattr_new)
> +{
> + mutex_lock(&sched_domains_mutex);
> + partition_sched_domains_locked(ndoms_new, doms_new, dattr_new);
> mutex_unlock(&sched_domains_mutex);
> }
Best,
- Juri
next prev parent reply other threads:[~2018-02-02 10:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 16:51 [PATCH V2 0/7] sched/deadline: fix cpusets bandwidth accounting Mathieu Poirier
2018-02-01 16:51 ` [PATCH V2 1/7] sched/topology: Adding function partition_sched_domains_locked() Mathieu Poirier
2018-02-02 10:19 ` Juri Lelli [this message]
2018-02-05 18:11 ` Mathieu Poirier
2018-02-06 7:42 ` Juri Lelli
2018-02-01 16:51 ` [PATCH V2 2/7] cpuset: Rebuild root domain deadline accounting information Mathieu Poirier
2018-02-02 12:52 ` Juri Lelli
2018-02-05 18:59 ` Mathieu Poirier
2018-02-01 16:51 ` [PATCH V2 3/7] sched/deadline: Keep new DL task within root domain's boundary Mathieu Poirier
2018-02-02 14:35 ` Juri Lelli
2018-02-05 18:58 ` Mathieu Poirier
2018-02-01 16:51 ` [PATCH V2 4/7] cgroup: Constrain 'sched_load_balance' flag when DL tasks are present Mathieu Poirier
2018-02-01 16:51 ` [PATCH V2 5/7] cgroup: Constrain the addition of CPUs to a new CPUset Mathieu Poirier
2018-02-01 16:51 ` [PATCH V2 6/7] sched/core: Don't change the affinity of DL tasks Mathieu Poirier
2018-02-01 16:51 ` [PATCH V2 7/7] sched/deadline: Prevent CPU hotplug operation if DL task on CPU Mathieu Poirier
2018-02-02 13:17 ` [PATCH V2 0/7] sched/deadline: fix cpusets bandwidth accounting Luca Abeni
2018-02-05 20:48 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202101951.GS19535@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=claudio@evidence.eu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tommaso.cucinotta@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox