Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Kees Cook]

On Wed, Dec 27, 2017 at 11:38 PM,  <zhuoweizhang@yahoo.com> wrote:
> From: Zhuowei Zhang <zhuoweizhang@yahoo.com>
>
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
>
> The address and configs are taken from the downstream kernel's device tree.
>
> Signed-off-by: Zhuowei Zhang <zhuoweizhang@yahoo.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
>                         pinctrl-1 = <&blsp1_uart2_sleep>;
>                 };
>         };
> +
> +       reserved-memory {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               ranges;
> +
> +               ramoops@1fe00000 {
> +                       compatible = "ramoops";
> +                       reg = <0 0x1fe00000 0 0x00200000>;
> +                       console-size = <0x100000>;
> +                       record-size = <0x10000>;
> +                       ftrace-size = <0x10000>;
> +                       pmsg-size = <0x80000>;
> +               };
> +       };
>  };
> --
> 1.9.1
>



-- 
Kees Cook
Pixel Security

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Jeremy McNicoll]

On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizhang@yahoo.com wrote:
> From: Zhuowei Zhang <zhuoweizhang@yahoo.com>
> 
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> 
> The address and configs are taken from the downstream kernel's device tree.
> 
> Signed-off-by: Zhuowei Zhang <zhuoweizhang@yahoo.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
>  			pinctrl-1 = <&blsp1_uart2_sleep>;
>  		};
>  	};
> +
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		ramoops@1fe00000 {
> +			compatible = "ramoops";
> +			reg = <0 0x1fe00000 0 0x00200000>;

Downstream doesn't use 0x0 to denote 0.  I am fine with this, if 
someone has a concern or issue with it we can change it before merging.


> +			console-size = <0x100000>;
> +			record-size = <0x10000>;
> +			ftrace-size = <0x10000>;
> +			pmsg-size = <0x80000>;

We could pad this with leading 0's but I find this much easier
to read.

> +		};
> +	};
>  };

Thank you very much for taking the time to send this.  


Acked-by: Jeremy McNicoll <jeremymc@redhat.com>

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

[Bjorn Andersson]

On Thu 11 Jan 18:33 PST 2018, Jeremy McNicoll wrote:

> On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizhang@yahoo.com wrote:
> > From: Zhuowei Zhang <zhuoweizhang@yahoo.com>
> > 
> > Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> > 
> > The address and configs are taken from the downstream kernel's device tree.
> > 
> > Signed-off-by: Zhuowei Zhang <zhuoweizhang@yahoo.com>

Hi Zhuowei,

This patch looks good, but I'm unable to find the original patch in my
inbox, at lkml.org or at patchwork.kernel.org. Can you please resend the
original patch to linux-arm-msm@vger.kernel.org, with Kees' R-b and
Jeremy's A-b.

Regards,
Bjorn