* Re: [PATCH] arm64: dts: angler: add pstore-ramoops support [not found] <1514446709-19347-1-git-send-email-zhuoweizhang@yahoo.com> @ 2018-01-02 18:09 ` Kees Cook 2018-01-12 2:33 ` Jeremy McNicoll 1 sibling, 0 replies; 3+ messages in thread From: Kees Cook @ 2018-01-02 18:09 UTC (permalink / raw) To: zhuoweizhang Cc: jeremymc, Andy Gross, David Brown, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Anton Vorontsov, Colin Cross, Tony Luck, linux-arm-msm, linux-soc, devicetree, linux-arm-kernel, LKML On Wed, Dec 27, 2017 at 11:38 PM, <zhuoweizhang@yahoo.com> wrote: > From: Zhuowei Zhang <zhuoweizhang@yahoo.com> > > Support pstore-ramoops for retrieving kernel oops and panics after reboot. > > The address and configs are taken from the downstream kernel's device tree. > > Signed-off-by: Zhuowei Zhang <zhuoweizhang@yahoo.com> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts > index dfa08f5..9ce3a6e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts > +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts > @@ -37,4 +37,19 @@ > pinctrl-1 = <&blsp1_uart2_sleep>; > }; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + ramoops@1fe00000 { > + compatible = "ramoops"; > + reg = <0 0x1fe00000 0 0x00200000>; > + console-size = <0x100000>; > + record-size = <0x10000>; > + ftrace-size = <0x10000>; > + pmsg-size = <0x80000>; > + }; > + }; > }; > -- > 1.9.1 > -- Kees Cook Pixel Security ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: angler: add pstore-ramoops support [not found] <1514446709-19347-1-git-send-email-zhuoweizhang@yahoo.com> 2018-01-02 18:09 ` [PATCH] arm64: dts: angler: add pstore-ramoops support Kees Cook @ 2018-01-12 2:33 ` Jeremy McNicoll 2018-02-02 19:27 ` Bjorn Andersson 1 sibling, 1 reply; 3+ messages in thread From: Jeremy McNicoll @ 2018-01-12 2:33 UTC (permalink / raw) To: zhuoweizhang Cc: jeremymc, Andy Gross, David Brown, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kees Cook, Anton Vorontsov, Colin Cross, Tony Luck, linux-arm-msm, linux-soc, devicetree, linux-arm-kernel, linux-kernel On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizhang@yahoo.com wrote: > From: Zhuowei Zhang <zhuoweizhang@yahoo.com> > > Support pstore-ramoops for retrieving kernel oops and panics after reboot. > > The address and configs are taken from the downstream kernel's device tree. > > Signed-off-by: Zhuowei Zhang <zhuoweizhang@yahoo.com> > --- > arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts > index dfa08f5..9ce3a6e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts > +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts > @@ -37,4 +37,19 @@ > pinctrl-1 = <&blsp1_uart2_sleep>; > }; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + ramoops@1fe00000 { > + compatible = "ramoops"; > + reg = <0 0x1fe00000 0 0x00200000>; Downstream doesn't use 0x0 to denote 0. I am fine with this, if someone has a concern or issue with it we can change it before merging. > + console-size = <0x100000>; > + record-size = <0x10000>; > + ftrace-size = <0x10000>; > + pmsg-size = <0x80000>; We could pad this with leading 0's but I find this much easier to read. > + }; > + }; > }; Thank you very much for taking the time to send this. Acked-by: Jeremy McNicoll <jeremymc@redhat.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: angler: add pstore-ramoops support 2018-01-12 2:33 ` Jeremy McNicoll @ 2018-02-02 19:27 ` Bjorn Andersson 0 siblings, 0 replies; 3+ messages in thread From: Bjorn Andersson @ 2018-02-02 19:27 UTC (permalink / raw) To: zhuoweizhang Cc: Jeremy McNicoll, jeremymc, Andy Gross, David Brown, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kees Cook, Anton Vorontsov, Colin Cross, Tony Luck, linux-arm-msm, linux-soc, devicetree, linux-arm-kernel, linux-kernel On Thu 11 Jan 18:33 PST 2018, Jeremy McNicoll wrote: > On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizhang@yahoo.com wrote: > > From: Zhuowei Zhang <zhuoweizhang@yahoo.com> > > > > Support pstore-ramoops for retrieving kernel oops and panics after reboot. > > > > The address and configs are taken from the downstream kernel's device tree. > > > > Signed-off-by: Zhuowei Zhang <zhuoweizhang@yahoo.com> Hi Zhuowei, This patch looks good, but I'm unable to find the original patch in my inbox, at lkml.org or at patchwork.kernel.org. Can you please resend the original patch to linux-arm-msm@vger.kernel.org, with Kees' R-b and Jeremy's A-b. Regards, Bjorn ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-02 19:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1514446709-19347-1-git-send-email-zhuoweizhang@yahoo.com>
2018-01-02 18:09 ` [PATCH] arm64: dts: angler: add pstore-ramoops support Kees Cook
2018-01-12 2:33 ` Jeremy McNicoll
2018-02-02 19:27 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox