From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <ak@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/3] perf tools: Fix period/freq terms setup
Date: Fri, 2 Feb 2018 17:40:04 -0300 [thread overview]
Message-ID: <20180202204004.GB8297@kernel.org> (raw)
In-Reply-To: <20180202202849.GA8297@kernel.org>
Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu:
> > Otherwise, I tested what you have written so far and it works.
> So I take that as a Tested-by: Stephane and will apply the patches, Jiri
> can continue working on these other aspects, right?
I also added this for the casual reader to get up to speed more quickly,
please check that it makes sense.
Committer note:
When we use -c or a period=N term in the event definition, then we don't
need to ask the kernel, via perf_event_attr.sample_type |=
PERF_SAMPLE_PERIOD, to put the event period in each sample, as we know
it already, it is in perf_event_attr.sample_period.
- Arnaldo
next prev parent reply other threads:[~2018-02-02 20:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 8:38 [PATCH 0/3] perf: PEBS/period freerunning fixes Jiri Olsa
2018-02-01 8:38 ` [PATCH 1/3] perf tools: Fix period/freq terms setup Jiri Olsa
2018-02-02 18:45 ` Stephane Eranian
2018-02-02 20:28 ` Arnaldo Carvalho de Melo
2018-02-02 20:40 ` Arnaldo Carvalho de Melo [this message]
2018-02-02 21:04 ` Stephane Eranian
2018-02-05 15:17 ` Jiri Olsa
2018-02-05 20:58 ` Stephane Eranian
2018-02-05 21:13 ` Arnaldo Carvalho de Melo
2018-02-06 2:51 ` Stephane Eranian
2018-02-06 9:35 ` Jiri Olsa
2018-02-07 18:52 ` Stephane Eranian
2018-02-09 9:27 ` [PATCH] perf report: Add support to display group output for non group events Jiri Olsa
2018-02-09 18:37 ` Arnaldo Carvalho de Melo
2018-02-09 18:43 ` Arnaldo Carvalho de Melo
2018-02-09 19:10 ` Jiri Olsa
2018-02-09 19:12 ` Arnaldo Carvalho de Melo
2018-02-17 11:23 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-02-03 15:30 ` [PATCH 1/3] perf tools: Fix period/freq terms setup Jiri Olsa
2018-02-04 0:19 ` Stephane Eranian
2018-02-05 21:35 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
2018-02-01 8:38 ` [PATCH 2/3] perf record: Fix period option handling Jiri Olsa
2018-02-05 21:36 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-02-01 8:38 ` [PATCH 3/3] x86/events/intel/ds: Add PERF_SAMPLE_PERIOD into PEBS_FREERUNNING_FLAGS Jiri Olsa
2018-02-05 21:36 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202204004.GB8297@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).