From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbeBBXTJ (ORCPT ); Fri, 2 Feb 2018 18:19:09 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36158 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbeBBXTC (ORCPT ); Fri, 2 Feb 2018 18:19:02 -0500 Date: Fri, 2 Feb 2018 15:17:53 -0800 From: "Paul E. McKenney" To: Andrea Parri Cc: Alan Stern , will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, linux-kernel@vger.kernel.org, mingo@kernel.org Subject: Re: [PATCH 1/2] tools/memory-model: clarify the origin/scope of the tool name Reply-To: paulmck@linux.vnet.ibm.com References: <1517486609-10951-1-git-send-email-parri.andrea@gmail.com> <20180201230941.GT3741@linux.vnet.ibm.com> <20180202085427.GA5456@andrea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180202085427.GA5456@andrea> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18020223-0024-0000-0000-0000031DE93F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008463; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000248; SDB=6.00984167; UDB=6.00499197; IPR=6.00763445; BA=6.00005809; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019342; XFM=3.00000015; UTC=2018-02-02 23:18:00 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020223-0025-0000-0000-000046DAA7C6 Message-Id: <20180202231753.GA3617@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-02_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802020280 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 02, 2018 at 09:54:27AM +0100, Andrea Parri wrote: > On Thu, Feb 01, 2018 at 03:09:41PM -0800, Paul E. McKenney wrote: > > On Thu, Feb 01, 2018 at 10:26:50AM -0500, Alan Stern wrote: > > > On Thu, 1 Feb 2018, Andrea Parri wrote: > > > > > > > Ingo pointed out that: > > > > > > > > "The "memory model" name is overly generic, ambiguous and somewhat > > > > misleading, as we usually mean the virtual memory layout/model > > > > when we say "memory model". GCC too uses it in that sense [...]" > > > > > > > > Make it clearer that, in the context of tools/memory-model/, the term > > > > "memory-model" is used as shorthand for "memory consistency model" by > > > > calling out this convention in tools/memory-model/README. > > > > > > > > Stick to the full name in sources' headers and for the subsystem name. > > > > > > > > Suggested-by: Ingo Molnar > > > > Signed-off-by: Andrea Parri > > > > > > For both patches: > > > > > > Acked-by: Alan Stern > > > > Thank you all -- I have queued this and pushed it to my RCU tree on > > branch lkmm. I did reword the commit log a bit, please see below and > > please let me know if any of my rewordings need halp. > > > > Andrea, when you resend your second patch, could you please add Alan's > > Acked-by? > > You mean in order to integrate Will's suggestion? I was planning to send > that as a separate patch, as suggested by Will: the patch is on its way, > IAC, please let me know if you'd prefer a V2 merging the two changes. Ah, apologies, I misread your reply. I have queued your second patch with Will's and Alan's Acked-by's. Thanx, Paul > Andrea > > > > > > Thanx, Paul > > > > ------------------------------------------------------------------------ > > > > commit de175b697f71b8e3e6d980b7186b909fee0c4378 > > Author: Andrea Parri > > Date: Thu Feb 1 13:03:29 2018 +0100 > > > > tools/memory-model: Clarify the origin/scope of the tool name > > > > Ingo pointed out that: > > > > "The "memory model" name is overly generic, ambiguous and somewhat > > misleading, as we usually mean the virtual memory layout/model > > when we say "memory model". GCC too uses it in that sense [...]" > > > > Make it clearer that tools/memory-model/ uses the term "memory model" > > is used as shorthand for "memory consistency model" by calling out this > > convention in tools/memory-model/README. > > > > Stick to the original "memory model" term in sources' headers and for > > the subsystem name. > > > > Suggested-by: Ingo Molnar > > Signed-off-by: Andrea Parri > > Acked-by: Will Deacon > > Acked-by: Alan Stern > > Signed-off-by: Paul E. McKenney > > > > diff --git a/tools/memory-model/MAINTAINERS b/tools/memory-model/MAINTAINERS > > index 711cbe72d606..db3bd3fc0435 100644 > > --- a/tools/memory-model/MAINTAINERS > > +++ b/tools/memory-model/MAINTAINERS > > @@ -1,4 +1,4 @@ > > -LINUX KERNEL MEMORY MODEL > > +LINUX KERNEL MEMORY CONSISTENCY MODEL > > M: Alan Stern > > M: Andrea Parri > > M: Will Deacon > > diff --git a/tools/memory-model/README b/tools/memory-model/README > > index 43ba49492111..91414a49fac5 100644 > > --- a/tools/memory-model/README > > +++ b/tools/memory-model/README > > @@ -1,15 +1,15 @@ > > - ========================= > > - LINUX KERNEL MEMORY MODEL > > - ========================= > > + ===================================== > > + LINUX KERNEL MEMORY CONSISTENCY MODEL > > + ===================================== > > > > ============ > > INTRODUCTION > > ============ > > > > -This directory contains the memory model of the Linux kernel, written > > -in the "cat" language and executable by the (externally provided) > > -"herd7" simulator, which exhaustively explores the state space of > > -small litmus tests. > > +This directory contains the memory consistency model (memory model, for > > +short) of the Linux kernel, written in the "cat" language and executable > > +by the externally provided "herd7" simulator, which exhaustively explores > > +the state space of small litmus tests. > > > > In addition, the "klitmus7" tool (also externally provided) may be used > > to convert a litmus test to a Linux kernel module, which in turn allows > > diff --git a/tools/memory-model/linux-kernel.bell b/tools/memory-model/linux-kernel.bell > > index 57112505f5e0..b984bbda01a5 100644 > > --- a/tools/memory-model/linux-kernel.bell > > +++ b/tools/memory-model/linux-kernel.bell > > @@ -11,7 +11,7 @@ > > * which is to appear in ASPLOS 2018. > > *) > > > > -"Linux kernel memory model" > > +"Linux-kernel memory consistency model" > > > > enum Accesses = 'once (*READ_ONCE,WRITE_ONCE,ACCESS_ONCE*) || > > 'release (*smp_store_release*) || > > diff --git a/tools/memory-model/linux-kernel.cat b/tools/memory-model/linux-kernel.cat > > index 15b7a5dd8a9a..babe2b3b0bb3 100644 > > --- a/tools/memory-model/linux-kernel.cat > > +++ b/tools/memory-model/linux-kernel.cat > > @@ -11,7 +11,7 @@ > > * which is to appear in ASPLOS 2018. > > *) > > > > -"Linux kernel memory model" > > +"Linux-kernel memory consistency model" > > > > (* > > * File "lock.cat" handles locks and is experimental. > > >