From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbeBBXqU (ORCPT ); Fri, 2 Feb 2018 18:46:20 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36263 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbeBBXqN (ORCPT ); Fri, 2 Feb 2018 18:46:13 -0500 X-Google-Smtp-Source: AH8x227iOWt9NbQuR3pEWv7dLw1DBttlJLoYsA/QYXqEIcUKcwbnEHssDdnJvE3S69nxgJlTETZtlA== Date: Sat, 3 Feb 2018 00:46:05 +0100 From: Andrea Parri To: "Paul E. McKenney" Cc: Alan Stern , will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, linux-kernel@vger.kernel.org, mingo@kernel.org Subject: Re: [PATCH 1/2] tools/memory-model: clarify the origin/scope of the tool name Message-ID: <20180202234605.GA4187@andrea> References: <1517486609-10951-1-git-send-email-parri.andrea@gmail.com> <20180201230941.GT3741@linux.vnet.ibm.com> <20180202104421.GA31828@andrea> <20180202231922.GB3617@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180202231922.GB3617@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 02, 2018 at 03:19:22PM -0800, Paul E. McKenney wrote: > On Fri, Feb 02, 2018 at 11:44:21AM +0100, Andrea Parri wrote: > > On Thu, Feb 01, 2018 at 03:09:41PM -0800, Paul E. McKenney wrote: > > > On Thu, Feb 01, 2018 at 10:26:50AM -0500, Alan Stern wrote: > > > > On Thu, 1 Feb 2018, Andrea Parri wrote: > > > > > > > > > Ingo pointed out that: > > > > > > > > > > "The "memory model" name is overly generic, ambiguous and somewhat > > > > > misleading, as we usually mean the virtual memory layout/model > > > > > when we say "memory model". GCC too uses it in that sense [...]" > > > > > > > > > > Make it clearer that, in the context of tools/memory-model/, the term > > > > > "memory-model" is used as shorthand for "memory consistency model" by > > > > > calling out this convention in tools/memory-model/README. > > > > > > > > > > Stick to the full name in sources' headers and for the subsystem name. > > > > > > > > > > Suggested-by: Ingo Molnar > > > > > Signed-off-by: Andrea Parri > > > > > > > > For both patches: > > > > > > > > Acked-by: Alan Stern > > > > > > Thank you all -- I have queued this and pushed it to my RCU tree on > > > branch lkmm. I did reword the commit log a bit, please see below and > > > please let me know if any of my rewordings need halp. > > > > Seems to me that your message has a leftover "is used". > > Good catch, how about this instead? Looks good to me. The same for 12a62a1d07031. Thanks, Andrea > > Thanx, Paul > > ----------------------------------------------------------------------- > > commit 2b1b4ab5166209da849f306fbdc84114d9e611fd > Author: Andrea Parri > Date: Thu Feb 1 13:03:29 2018 +0100 > > tools/memory-model: Clarify the origin/scope of the tool name > > Ingo pointed out that: > > "The "memory model" name is overly generic, ambiguous and somewhat > misleading, as we usually mean the virtual memory layout/model > when we say "memory model". GCC too uses it in that sense [...]" > > Make it clear that tools/memory-model/ uses the term "memory model" as > shorthand for "memory consistency model" by calling out this convention > in tools/memory-model/README. > > Stick to the original "memory model" term in sources' headers and for > the subsystem name. > > Suggested-by: Ingo Molnar > Signed-off-by: Andrea Parri > Acked-by: Will Deacon > Acked-by: Alan Stern > Signed-off-by: Paul E. McKenney > > diff --git a/tools/memory-model/MAINTAINERS b/tools/memory-model/MAINTAINERS > index 711cbe72d606..db3bd3fc0435 100644 > --- a/tools/memory-model/MAINTAINERS > +++ b/tools/memory-model/MAINTAINERS > @@ -1,4 +1,4 @@ > -LINUX KERNEL MEMORY MODEL > +LINUX KERNEL MEMORY CONSISTENCY MODEL > M: Alan Stern > M: Andrea Parri > M: Will Deacon > diff --git a/tools/memory-model/README b/tools/memory-model/README > index 43ba49492111..91414a49fac5 100644 > --- a/tools/memory-model/README > +++ b/tools/memory-model/README > @@ -1,15 +1,15 @@ > - ========================= > - LINUX KERNEL MEMORY MODEL > - ========================= > + ===================================== > + LINUX KERNEL MEMORY CONSISTENCY MODEL > + ===================================== > > ============ > INTRODUCTION > ============ > > -This directory contains the memory model of the Linux kernel, written > -in the "cat" language and executable by the (externally provided) > -"herd7" simulator, which exhaustively explores the state space of > -small litmus tests. > +This directory contains the memory consistency model (memory model, for > +short) of the Linux kernel, written in the "cat" language and executable > +by the externally provided "herd7" simulator, which exhaustively explores > +the state space of small litmus tests. > > In addition, the "klitmus7" tool (also externally provided) may be used > to convert a litmus test to a Linux kernel module, which in turn allows > diff --git a/tools/memory-model/linux-kernel.bell b/tools/memory-model/linux-kernel.bell > index 57112505f5e0..b984bbda01a5 100644 > --- a/tools/memory-model/linux-kernel.bell > +++ b/tools/memory-model/linux-kernel.bell > @@ -11,7 +11,7 @@ > * which is to appear in ASPLOS 2018. > *) > > -"Linux kernel memory model" > +"Linux-kernel memory consistency model" > > enum Accesses = 'once (*READ_ONCE,WRITE_ONCE,ACCESS_ONCE*) || > 'release (*smp_store_release*) || > diff --git a/tools/memory-model/linux-kernel.cat b/tools/memory-model/linux-kernel.cat > index 15b7a5dd8a9a..babe2b3b0bb3 100644 > --- a/tools/memory-model/linux-kernel.cat > +++ b/tools/memory-model/linux-kernel.cat > @@ -11,7 +11,7 @@ > * which is to appear in ASPLOS 2018. > *) > > -"Linux kernel memory model" > +"Linux-kernel memory consistency model" > > (* > * File "lock.cat" handles locks and is experimental. >