From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined
Date: Sun, 4 Feb 2018 11:21:36 +0000 [thread overview]
Message-ID: <20180204112136.6c9ad790@archlinux> (raw)
In-Reply-To: <20180201204924.GA26839@arbeit>
On Thu, 1 Feb 2018 21:49:24 +0100
Andreas Klinger <ak@it-klinger.de> wrote:
> Functions for triggered buffer support are needed by this module.
> If they are not defined accidentally by another driver, there's an error
> thrown out while linking.
>
> Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
Applied to the fixes-togreg-post-rc1 branch of iio.git with a fixes
tag added. Please always track down the patch that introduced the
problem and add a fixes tag. It makes it much easier for the stable
trees to know when to apply the patch or not.
I put the patch that introduced the triggered support in the first
place as that seemed likely to be the place that the issue was
introduced.
Thanks,
Jonathan
> ---
> drivers/iio/proximity/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig
> index fcb1c4ba5e41..f726f9427602 100644
> --- a/drivers/iio/proximity/Kconfig
> +++ b/drivers/iio/proximity/Kconfig
> @@ -68,6 +68,8 @@ config SX9500
>
> config SRF08
> tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
> + select IIO_BUFFER
> + select IIO_TRIGGERED_BUFFER
> depends on I2C
> help
> Say Y here to build a driver for Devantech SRF02/SRF08/SRF10
prev parent reply other threads:[~2018-02-04 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 20:49 [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined Andreas Klinger
2018-02-04 11:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180204112136.6c9ad790@archlinux \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).