* Re: [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
2018-01-23 16:42 [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Anson Huang
@ 2018-01-23 13:47 ` Lucas Stach
2018-01-23 16:42 ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-01-23 13:47 UTC (permalink / raw)
To: Anson Huang, shawnguo, kernel, fabio.estevam, robh+dt,
aisheng.dong, mark.rutland, linux
Cc: devicetree, Linux-imx, linux-arm-kernel, linux-kernel
Am Mittwoch, den 24.01.2018, 00:42 +0800 schrieb Anson Huang:
> ARM power domain does NOT support runtime off, always-on
> flag should be set to avoid incorrect power state in
> pm_genpd_summary:
>
> Before:
>
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> ARM off-0
>
> After:
>
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> ARM on
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/soc/imx/gpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 53f7275..6cafa9b 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -254,6 +254,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
> > {
> > .base = {
> > .name = "ARM",
> > + .flags = GENPD_FLAG_ALWAYS_ON,
> > },
> > }, {
> > .base = {
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
2018-01-23 16:42 [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Anson Huang
2018-01-23 13:47 ` Lucas Stach
@ 2018-01-23 16:42 ` Anson Huang
2018-01-23 13:48 ` Lucas Stach
2018-01-25 10:33 ` Dong Aisheng
2018-01-25 10:29 ` [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Dong Aisheng
2018-02-05 6:33 ` Shawn Guo
3 siblings, 2 replies; 7+ messages in thread
From: Anson Huang @ 2018-01-23 16:42 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, robh+dt, aisheng.dong,
mark.rutland, linux
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel
Add ARM power domain in PGC.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 42ef4c6..aa29ca6 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -768,6 +768,11 @@
#address-cells = <1>;
#size-cells = <0>;
+ power-domain@0 {
+ reg = <0>;
+ #power-domain-cells = <0>;
+ };
+
pd_pu: power-domain@1 {
reg = <1>;
#power-domain-cells = <0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
2018-01-23 16:42 ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
@ 2018-01-23 13:48 ` Lucas Stach
2018-01-25 10:33 ` Dong Aisheng
1 sibling, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-01-23 13:48 UTC (permalink / raw)
To: Anson Huang, shawnguo, kernel, fabio.estevam, robh+dt,
aisheng.dong, mark.rutland, linux
Cc: devicetree, Linux-imx, linux-arm-kernel, linux-kernel
Am Mittwoch, den 24.01.2018, 00:42 +0800 schrieb Anson Huang:
> Add ARM power domain in PGC.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
> arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 42ef4c6..aa29ca6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -768,6 +768,11 @@
> > #address-cells = <1>;
> > #size-cells = <0>;
>
> > + power-domain@0 {
> > + reg = <0>;
> > + #power-domain-cells = <0>;
> > + };
> +
> > > pd_pu: power-domain@1 {
> > reg = <1>;
> > #power-domain-cells = <0>;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
2018-01-23 16:42 ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
2018-01-23 13:48 ` Lucas Stach
@ 2018-01-25 10:33 ` Dong Aisheng
1 sibling, 0 replies; 7+ messages in thread
From: Dong Aisheng @ 2018-01-25 10:33 UTC (permalink / raw)
To: Anson Huang
Cc: shawnguo, kernel, fabio.estevam, robh+dt, aisheng.dong,
mark.rutland, linux, Linux-imx, linux-arm-kernel, devicetree,
linux-kernel
On Wed, Jan 24, 2018 at 12:42:14AM +0800, Anson Huang wrote:
> Add ARM power domain in PGC.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
> arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 42ef4c6..aa29ca6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -768,6 +768,11 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + power-domain@0 {
Nitpick: probably an 'arm' prefix is better:
arm: power-domain@0
Anyway, it's minor depends on maintainer's perference.
Otherwise, looks fine
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
> + reg = <0>;
> + #power-domain-cells = <0>;
> + };
> +
> pd_pu: power-domain@1 {
> reg = <1>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
2018-01-23 16:42 [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Anson Huang
2018-01-23 13:47 ` Lucas Stach
2018-01-23 16:42 ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
@ 2018-01-25 10:29 ` Dong Aisheng
2018-02-05 6:33 ` Shawn Guo
3 siblings, 0 replies; 7+ messages in thread
From: Dong Aisheng @ 2018-01-25 10:29 UTC (permalink / raw)
To: Anson Huang
Cc: shawnguo, kernel, fabio.estevam, robh+dt, aisheng.dong,
mark.rutland, linux, Linux-imx, linux-arm-kernel, devicetree,
linux-kernel
On Wed, Jan 24, 2018 at 12:42:13AM +0800, Anson Huang wrote:
> ARM power domain does NOT support runtime off, always-on
> flag should be set to avoid incorrect power state in
> pm_genpd_summary:
>
> Before:
>
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> ARM off-0
>
> After:
>
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> ARM on
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
2018-01-23 16:42 [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Anson Huang
` (2 preceding siblings ...)
2018-01-25 10:29 ` [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Dong Aisheng
@ 2018-02-05 6:33 ` Shawn Guo
3 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-02-05 6:33 UTC (permalink / raw)
To: Anson Huang
Cc: kernel, fabio.estevam, robh+dt, aisheng.dong, mark.rutland, linux,
Linux-imx, linux-arm-kernel, devicetree, linux-kernel
On Wed, Jan 24, 2018 at 12:42:13AM +0800, Anson Huang wrote:
> ARM power domain does NOT support runtime off, always-on
> flag should be set to avoid incorrect power state in
> pm_genpd_summary:
>
> Before:
>
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> ARM off-0
>
> After:
>
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> ARM on
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread