From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Dmitry Safonov <0x7f454c46@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] apparent bogosity in unregister_ftrace_function_probe_func()
Date: Mon, 5 Feb 2018 21:40:11 -0500 [thread overview]
Message-ID: <20180205214011.2d55866e@vmware.local.home> (raw)
In-Reply-To: <20180206112614.80e2a9cbfc55954ab904c3e3@kernel.org>
On Tue, 6 Feb 2018 11:26:14 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> No, that code looks good to me. :)
>
> BTW, did you also remove "search = buff;" line in
> unregister_ftrace_function_probe_func() too?
That's a separate bug, and should be a separate patch. Dmitry mentioned
that he was preparing a patch to fix that.
Dmitry did you have a patch and added selftests to check it? If not,
I'll whip one up.
Thanks,
-- Steve
next prev parent reply other threads:[~2018-02-06 2:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 3:17 [RFC] apparent bogosity in unregister_ftrace_function_probe_func() Al Viro
2018-01-27 13:59 ` Dmitry Safonov
2018-01-27 17:07 ` Al Viro
2018-01-28 10:31 ` Steven Rostedt
2018-01-29 13:59 ` Masami Hiramatsu
2018-02-05 22:54 ` Steven Rostedt
2018-02-06 1:25 ` Dmitry Safonov
2018-02-06 2:26 ` Masami Hiramatsu
2018-02-06 2:40 ` Steven Rostedt [this message]
2018-02-06 2:44 ` Dmitry Safonov
2018-02-06 2:48 ` Steven Rostedt
2018-02-06 2:53 ` Dmitry Safonov
2018-01-29 13:49 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205214011.2d55866e@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=0x7f454c46@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).