From: Darren Hart <dvhart@infradead.org>
To: Mario.Limonciello@dell.com
Cc: andy.shevchenko@gmail.com, pali.rohar@gmail.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: dell-laptop: Allocate buffer on heap rather than globally
Date: Mon, 5 Feb 2018 16:57:33 -0800 [thread overview]
Message-ID: <20180206005733.GA11119@fury> (raw)
In-Reply-To: <9b01161fb81043b79cf9ade8ec348fff@ausx13mpc120.AMER.DELL.COM>
On Mon, Feb 05, 2018 at 04:49:35PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> > Sent: Sunday, February 4, 2018 8:28 AM
> > To: Pali Rohár <pali.rohar@gmail.com>
> > Cc: Limonciello, Mario <Mario_Limonciello@Dell.com>; Darren Hart
> > <dvhart@infradead.org>; LKML <linux-kernel@vger.kernel.org>; Platform Driver
> > <platform-driver-x86@vger.kernel.org>
> > Subject: Re: [PATCH v2] platform/x86: dell-laptop: Allocate buffer on heap rather
> > than globally
> >
> > On Sun, Feb 4, 2018 at 2:09 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > > On Wednesday 31 January 2018 11:47:35 Mario Limonciello wrote:
> > >> There is no longer a need for the buffer to be defined in
> > >> first 4GB physical address space.
> > >>
> > >> Furthermore there may be race conditions with multiple different functions
> > >> working on a module wide buffer causing incorrect results.
> > >>
> > >> Fixes: 549b4930f057658dc50d8010e66219233119a4d8
> >
> > He-h, I had to notice this earlier...
> >
> > > Ok, you can add my:
> > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > Thanks and sorry, Pali, it's in for-next already, can't rebase.
>
> Andy,
> Since it's already in for-next it's probably too late to add the stable CC too right?
>
> So what's the proper time now to send this to @stable? And should I just forward existing
> patch?
As a general rule, Andy and I should be adding Cc stable to most anything that
includes a Fixes tag that isn't from this review cycle. I've forgotten in the
past as well - sorry about that. Something we should add some tooling around I
think, so we don't miss it when checking things in to our review branches.
As to timing. As soon as this is merged to Linus' master, it can go to stable.
Instructions for doing this are in Documentation/process/stable-kernel-rules.rst
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-02-06 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 17:47 [PATCH v2] platform/x86: dell-laptop: Allocate buffer on heap rather than globally Mario Limonciello
2018-01-31 18:40 ` Andy Shevchenko
2018-02-04 12:09 ` Pali Rohár
2018-02-04 14:27 ` Andy Shevchenko
2018-02-05 16:49 ` Mario.Limonciello
2018-02-06 0:57 ` Darren Hart [this message]
2018-02-07 20:17 ` Mario.Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206005733.GA11119@fury \
--to=dvhart@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox