From: Andrew Lunn <andrew@lunn.ch>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Sven Van Asbroeck <svendev@arcx.com>,
Woojung.Huh@microchip.com, Tristram.Ha@microchip.com,
f.fainelli@gmail.com, helmut.buchsbaum@gmail.com,
Maarten.Blomme@flir.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.
Date: Tue, 6 Feb 2018 17:50:09 +0100 [thread overview]
Message-ID: <20180206165009.GJ12679@lunn.ch> (raw)
In-Reply-To: <CAGngYiWYChnZmU7n9i1+nbY+1oWGXQGOopBhNiPHPUoYvTdgaw@mail.gmail.com>
On Tue, Feb 06, 2018 at 11:41:14AM -0500, Sven Van Asbroeck wrote:
> On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn <andrew@lunn.ch> wrote:
> > Rather than invest time in this driver, it would be better to look
> > into writing a DSA driver.
>
> Thank you Andrew. I know little of DSA, but at first sight it appears to
> be a _very_ complicated beast for a switch PHY which only
> needs a few static register settings applied to it on startup, and has
> no further Linux interaction?
Hi Sven
If you want to treat it as a dumb switch, then a simple driver is
sufficient. But it can do a lot more. Do you need spanning tree, or
are you happy for your network to collapse if there is a loop? Do you
want access to statistics? Know if links are up/down? VLAN support?
Save some power by enabling EEE? DSA will give you these features.
And a DSA driver does not need to be complex. You can start simple,
and add more features later.
Andrew
next prev parent reply other threads:[~2018-02-06 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:13 [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers Sven Van Asbroeck
2018-02-06 15:13 ` [PATCH v1 1/1] " Sven Van Asbroeck
2018-02-08 2:49 ` David Miller
2018-02-06 16:14 ` [PATCH v1 0/1] " Andrew Lunn
2018-02-06 16:41 ` Sven Van Asbroeck
2018-02-06 16:50 ` Andrew Lunn [this message]
2018-02-06 16:58 ` Sven Van Asbroeck
2018-02-06 17:05 ` Andrew Lunn
2018-02-06 17:47 ` Florian Fainelli
2018-02-06 18:11 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206165009.GJ12679@lunn.ch \
--to=andrew@lunn.ch \
--cc=Maarten.Blomme@flir.com \
--cc=Tristram.Ha@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=f.fainelli@gmail.com \
--cc=helmut.buchsbaum@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=svendev@arcx.com \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox