From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753371AbeBFTZG (ORCPT ); Tue, 6 Feb 2018 14:25:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:35676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbeBFTZE (ORCPT ); Tue, 6 Feb 2018 14:25:04 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06CA82172C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 6 Feb 2018 16:15:23 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Ingo Molnar , Namhyung Kim , David Ahern , Alexander Shishkin , Peter Zijlstra Subject: Re: [PATCH 16/17] perf tests: Fix dwarf unwind for stripped binaries Message-ID: <20180206191523.GH3451@kernel.org> References: <20180206181813.10943-1-jolsa@kernel.org> <20180206181813.10943-17-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180206181813.10943-17-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Feb 06, 2018 at 07:18:12PM +0100, Jiri Olsa escreveu: > When we strip the perf binary, dwarf unwind test stop > to work. The reason is that strip will remove static > function symbols, which we need to check for unwind. > > This change will keep this test working in cases where > the global symbols are put into dynamic symbol table, > which is the case on x86. It still won't work on powerpc. > > Making those 5 local functions global, and adding > 'test_dwarf_unwind__' to their names. Tested, applied. - Arnaldo