From: Theodore Ts'o <tytso@mit.edu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jin Qian <jinqian@android.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jin Qian <jinqian@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem
Date: Tue, 6 Feb 2018 18:11:49 -0500 [thread overview]
Message-ID: <20180206231149.GC1977@thunk.org> (raw)
In-Reply-To: <20180206203953.GC18045@kroah.com>
On Tue, Feb 06, 2018 at 12:39:53PM -0800, Greg KH wrote:
> On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote:
> > From: Jin Qian <jinqian@google.com>
> >
> > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream
> > to v4.4 to prevent virt_to_page on highmem.
>
> Ted, any objection to this patch?
No objections with my ext4 hat on.
It should be noted though that this is a partial backport because it
only fixes ext4, while Al's original upstream fix addressed a much
larger set of file systems. In the Android kernel the f2fs fix had
been backported separately. But for the upstream kernel, it *might*
be the case that we should try backporting the original commit so that
in case there is some other general purpose distribution decides (a)
to base their system on 4.4, and (b) support a 32-bit kernel, they get
the more general bug fixes which applies for btrfs, isofs, ocfs2, nfs,
etc.
I haevn't been paying attention to what LTS kernels general purpose
distro's are using, so I don't know how important this would be. And
if there are companies like Cloudflare which are using upstream LTS
kernel, it seems unlikely they would want to use a 32-bit kernel,
so.... shrug. Greg, I'll let you decide if you want to backport the
full commit or not.
(We had a similar discussion on the AOSP kernel, and came to the
conclusion that we only needed to make the patch support ext4. No one
was going to test the other file systems besides ext4 and f2fs,
anyway. But the calculus might be different might be different for
the general upstream LTS kernel.)
- Ted
next prev parent reply other threads:[~2018-02-06 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 19:09 [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem Jin Qian
2018-02-06 20:39 ` Greg KH
2018-02-06 23:11 ` Theodore Ts'o [this message]
2018-02-06 23:38 ` Eric Biggers
2018-02-06 23:56 ` Jin Qian
2018-02-07 2:16 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206231149.GC1977@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=bfields@fieldses.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinqian@android.com \
--cc=jinqian@google.com \
--cc=jlayton@poochiereds.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).