From: Greg KH <gregkh@linuxfoundation.org>
To: Jin Qian <jinqian@android.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Changman Lee <cm224.lee@samsung.com>,
Chao Yu <chao2.yu@samsung.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, Jin Qian <jinqian@google.com>,
linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCHv2 1/1] ext4/f2fs: don't put symlink in pagecache into highmem
Date: Wed, 7 Feb 2018 12:06:04 -0800 [thread overview]
Message-ID: <20180207200604.GB15309@kroah.com> (raw)
In-Reply-To: <20180206235354.79591-1-jinqian@android.com>
Some minor nits for when you send your next patch for stable:
On Tue, Feb 06, 2018 at 03:53:53PM -0800, Jin Qian wrote:
> From: Jin Qian <jinqian@google.com>
The original patch was written by Al Viro, please do not take the
original authorship off, that's not good.
> partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream
> to v4.4 to prevent virt_to_page on highmem.
>
> ext4_encrypted_follow_link uses kmap() for cpage
> caddr = kmap(cpage);
>
> _ext4_fname_disk_to_usr calls virt_to_page on the kmapped address.
> _ext4_fname_disk_to_usr()
> ext4_fname_decrypt()
> sg_init_one()
> sg_init_one(&src_sg, iname->name, iname->len);
> sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));
>
> Cc: linux-stable <stable@vger.kernel.org> # 4.4.y
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Jin Qian <jinqian@google.com>
> Signed-off-by: Jin Qian <jinqian@android.com>
Why did you sign off on this twice?
thanks,
greg k-h
next prev parent reply other threads:[~2018-02-07 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 23:53 [PATCHv2 1/1] ext4/f2fs: don't put symlink in pagecache into highmem Jin Qian
2018-02-07 20:06 ` Greg KH [this message]
2018-02-07 21:24 ` Jin Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207200604.GB15309@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=bfields@fieldses.org \
--cc=chao2.yu@samsung.com \
--cc=cm224.lee@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=jinqian@android.com \
--cc=jinqian@google.com \
--cc=jlayton@poochiereds.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox