Re: [PATCH v5 1/4] cpu_pm: add syscore_suspend error handling

Marc Zyngier
2018-02-07T08:57:33Z

On 07/02/18 01:41, Derek Basehore wrote:
> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This
> will put the CPU in the correct state to resume from the failure.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
> kernel/cpu_pm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/cpu_pm.c b/kernel/cpu_pm.c
> index 67b02e138a47..03bcc0751a51 100644
> --- a/kernel/cpu_pm.c
> +++ b/kernel/cpu_pm.c
> @@ -186,6 +186,9 @@ static int cpu_pm_suspend(void)
> return ret;
>
> ret = cpu_cluster_pm_enter();
> + if (ret)
> + cpu_pm_exit();
> +
> return ret;
> }
>
>

It is unclear to me why we need this patch as part of the ITS series. I
probably fixes something for you, but I don't see the connection with
the other patches.

Thanks,

M.
--
Jazz is not dead. It just smells funny...